Skip to content

Commit d62593e

Browse files
merwokfabiocaccamo
andauthored
Drop old Python and Django versions (#220)
* drop old python and django versions * fix tests * remove compat module entirely Co-authored-by: Fabio Caccamo <[email protected]>
1 parent 333025f commit d62593e

24 files changed

+34
-244
lines changed

.github/workflows/test-package.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ jobs:
1919
id: create_matrix
2020
with:
2121
matrix: |
22-
python-version {2.7}, django-version {1.8,1.9,1.10,1.11}, database {sqlite,postgres}
23-
python-version {3.6}, django-version {1.8,1.9,1.10,1.11,2.0,2.1,2.2,3.0,3.1,3.2}, database {sqlite,postgres}
24-
python-version {3.7}, django-version {2.0,2.1,2.2,3.0,3.1,3.2}, database {sqlite,postgres}
2522
python-version {3.8}, django-version {2.2,3.0,3.1,3.2}, database {sqlite,postgres}
2623
python-version {3.9}, django-version {2.2,3.0,3.1,3.2}, database {sqlite,postgres}
2724
python-version {3.10}, django-version {3.2,4.0,4.1}, database {sqlite,postgres}

README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,20 +47,17 @@ django-admin-interface is a modern **responsive flat admin interface customizabl
4747

4848
## Installation
4949
- Run `pip install django-admin-interface`
50-
- Add `admin_interface`, `flat_responsive`, `flat` and `colorfield` to `settings.INSTALLED_APPS` **before** `django.contrib.admin`
50+
- Add `admin_interface` and `colorfield` to `settings.INSTALLED_APPS` **before** `django.contrib.admin`
5151
```python
5252
INSTALLED_APPS = (
5353
#...
5454
"admin_interface",
55-
"flat_responsive", # only if django version < 2.0
56-
"flat", # only if django version < 1.9
5755
"colorfield",
5856
#...
5957
"django.contrib.admin",
6058
#...
6159
)
6260

63-
# only if django version >= 3.0
6461
X_FRAME_OPTIONS = "SAMEORIGIN"
6562
SILENCED_SYSTEM_CHECKS = ["security.W019"]
6663
```

admin_interface/admin.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
1-
# -*- coding: utf-8 -*-
2-
31
from django.contrib import admin
2+
from django.utils.translation import gettext_lazy as _
43

5-
from admin_interface.compat import gettext_lazy as _
64
from admin_interface.models import Theme
75

86

admin_interface/apps.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
1-
# -*- coding: utf-8 -*-
2-
31
from django.apps import AppConfig
42
from django.db.models.signals import post_migrate
5-
6-
from admin_interface.compat import gettext_lazy as _
3+
from django.utils.translation import gettext_lazy as _
74

85

96
class AdminInterfaceConfig(AppConfig):

admin_interface/cache.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# -*- coding: utf-8 -*-
2-
31
from django.conf import settings
42
from django.core.cache import cache, caches
53

admin_interface/compat.py

Lines changed: 0 additions & 26 deletions
This file was deleted.

admin_interface/migrations/0021_file_extension_validator.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22

33
from __future__ import unicode_literals
44

5+
from django.core.validators import FileExtensionValidator
56
from django.db import migrations, models
67

7-
from admin_interface.compat import FileExtensionValidator
8-
98

109
class Migration(migrations.Migration):
1110

admin_interface/models.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,13 @@
1-
# -*- coding: utf-8 -*-
2-
3-
from __future__ import unicode_literals
4-
51
from colorfield.fields import ColorField
2+
from django.core.validators import FileExtensionValidator
63
from django.db import models
74
from django.db.models.signals import post_delete, post_save, pre_save
8-
from six import python_2_unicode_compatible
5+
from django.utils.encoding import force_str
6+
from django.utils.translation import gettext_lazy as _
97

10-
from admin_interface.cache import del_cached_active_theme
11-
from admin_interface.compat import FileExtensionValidator, force_str
12-
from admin_interface.compat import gettext_lazy as _
8+
from .cache import del_cached_active_theme
139

1410

15-
@python_2_unicode_compatible
1611
class Theme(models.Model):
1712
@staticmethod
1813
def post_migrate_handler(**kwargs):

admin_interface/settings.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# -*- coding: utf-8 -*-
2-
31
import django
42
from django.conf import settings
53
from django.core.exceptions import ImproperlyConfigured
@@ -29,5 +27,3 @@ def check_installed_app(app, max_dj_version=None):
2927

3028
def check_installed_apps():
3129
check_installed_app("colorfield")
32-
check_installed_app("flat", max_dj_version=(1, 9))
33-
check_installed_app("flat_responsive", max_dj_version=(2, 0))

admin_interface/static/admin/js/popup_response.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,7 @@
4242
if (typeof(openerRef.dismissAddRelatedObjectPopup) === 'function') {
4343
openerRef.dismissAddRelatedObjectPopup(windowRef, initData.value, initData.obj);
4444
}
45-
else if (typeof(openerRef.dismissAddAnotherPopup) === 'function') {
46-
// django 1.7 compatibility
47-
openerRef.dismissAddAnotherPopup(windowRef, initData.value, initData.obj);
48-
}
4945
break;
5046
}
5147

52-
})();
48+
})();

0 commit comments

Comments
 (0)