🐛 FIX: container plugin \w no newline (#43)

Fixed an `IndexError` when there is no newline on the closing tag line.

Author: chrisjsewell

MANIFEST.in

@@ -12,6 +12,7 @@ exclude docstring.fmt.mustache
 exclude .flake8
 exclude .circleci
 exclude .circleci/config.yml
+exclude codecov.yml
 
 include LICENSE
 include LICENSE.markdown-it

codecov.yml

@@ -0,0 +1,10 @@
+coverage:
+  status:
+    project:
+      default:
+        target: 95%
+        threshold: 0.2%
+    patch:
+      default:
+        target: 80%
+        threshold: 0.2%

markdown_it/extensions/container/index.py

@@ -42,7 +42,11 @@ def container_func(state: StateBlock, startLine: int, endLine: int, silent: bool
         # Check out the rest of the marker string
         pos = start + 1
         while pos <= maximum:
-            if marker_str[(pos - start) % marker_len] != state.src[pos]:
+            try:
+                character = state.src[pos]
+            except IndexError:
+                break
+            if marker_str[(pos - start) % marker_len] != character:
                 break
             pos += 1
 
@@ -88,7 +92,11 @@ def container_func(state: StateBlock, startLine: int, endLine: int, silent: bool
 
             pos = start + 1
             while pos <= maximum:
-                if marker_str[(pos - start) % marker_len] != state.src[pos]:
+                try:
+                    character = state.src[pos]
+                except IndexError:
+                    break
+                if marker_str[(pos - start) % marker_len] != character:
                     break
                 pos += 1
 

tests/test_plugins/test_container.py

@@ -22,6 +22,20 @@ def test_plugin_parse(data_regression):
     data_regression.check([t.as_dict() for t in tokens])
 
 
+def test_no_new_line_issue(data_regression):
+    """Fixed an IndexError when no newline on final line."""
+    md = MarkdownIt().use(container_plugin, "name")
+    tokens = md.parse(
+        dedent(
+            """\
+    ::: name
+    *content*
+    :::"""
+        )
+    )
+    data_regression.check([t.as_dict() for t in tokens])
+
+
 FIXTURE_PATH = Path(__file__).parent.joinpath("fixtures", "container.md")
 
 

tests/test_plugins/test_container/test_no_new_line_issue.yml

@@ -0,0 +1,110 @@
+- attrs: null
+  block: true
+  children: null
+  content: ''
+  hidden: false
+  info: ' name'
+  level: 0
+  map:
+  - 0
+  - 2
+  markup: ':::'
+  meta: {}
+  nesting: 1
+  tag: div
+  type: container_name_open
+- attrs: null
+  block: true
+  children: null
+  content: ''
+  hidden: false
+  info: ''
+  level: 1
+  map:
+  - 1
+  - 2
+  markup: ''
+  meta: {}
+  nesting: 1
+  tag: p
+  type: paragraph_open
+- attrs: null
+  block: true
+  children:
+  - attrs: null
+    block: false
+    children: null
+    content: ''
+    hidden: false
+    info: ''
+    level: 0
+    map: null
+    markup: '*'
+    meta: {}
+    nesting: 1
+    tag: em
+    type: em_open
+  - attrs: null
+    block: false
+    children: null
+    content: content
+    hidden: false
+    info: ''
+    level: 1
+    map: null
+    markup: ''
+    meta: {}
+    nesting: 0
+    tag: ''
+    type: text
+  - attrs: null
+    block: false
+    children: null
+    content: ''
+    hidden: false
+    info: ''
+    level: 0
+    map: null
+    markup: '*'
+    meta: {}
+    nesting: -1
+    tag: em
+    type: em_close
+  content: '*content*'
+  hidden: false
+  info: ''
+  level: 2
+  map:
+  - 1
+  - 2
+  markup: ''
+  meta: {}
+  nesting: 0
+  tag: ''
+  type: inline
+- attrs: null
+  block: true
+  children: null
+  content: ''
+  hidden: false
+  info: ''
+  level: 1
+  map: null
+  markup: ''
+  meta: {}
+  nesting: -1
+  tag: p
+  type: paragraph_close
+- attrs: null
+  block: true
+  children: null
+  content: ''
+  hidden: false
+  info: ''
+  level: 0
+  map: null
+  markup: ':::'
+  meta: {}
+  nesting: -1
+  tag: div
+  type: container_name_close