Merge pull request #738 from phoddie/patch-1

me-no-dev · web-flow · commit 1480dca102ac · 2025-06-30T20:01:05.000+03:00
contrast fixes
diff --git a/sensors/gc0308.c b/sensors/gc0308.c
@@ -279,7 +279,8 @@ static int set_framesize(sensor_t *sensor, framesize_t framesize)
 
 static int set_contrast(sensor_t *sensor, int contrast)
 {
-    if (contrast != 0) {
+    if (contrast > 0) {
+        sensor->status.contrast = contrast;
         write_reg(sensor->slv_addr, 0xfe, 0x00);
         write_reg(sensor->slv_addr, 0xb3, contrast);
     }
@@ -370,7 +371,7 @@ static int init_status(sensor_t *sensor)
 {
     write_reg(sensor->slv_addr, 0xfe, 0x00);
     sensor->status.brightness = 0;
-    sensor->status.contrast = 0;
+    sensor->status.contrast = 50;
     sensor->status.saturation = 0;
     sensor->status.sharpness = 0;
     sensor->status.denoise = 0;

Original file line number	Diff line number	Diff line change
`@@ -279,7 +279,8 @@ static int set_framesize(sensor_t *sensor, framesize_t framesize)`
`279`	`279`
`280`	`280`	`static int set_contrast(sensor_t *sensor, int contrast)`
`281`	`281`	`{`
`282`		`- if (contrast != 0) {`
	`282`	`+ if (contrast > 0) {`
	`283`	`+ sensor->status.contrast = contrast;`
`283`	`284`	`write_reg(sensor->slv_addr, 0xfe, 0x00);`
`284`	`285`	`write_reg(sensor->slv_addr, 0xb3, contrast);`
`285`	`286`	`}`
`@@ -370,7 +371,7 @@ static int init_status(sensor_t *sensor)`
`370`	`371`	`{`
`371`	`372`	`write_reg(sensor->slv_addr, 0xfe, 0x00);`
`372`	`373`	`sensor->status.brightness = 0;`
`373`		`- sensor->status.contrast = 0;`
	`374`	`+ sensor->status.contrast = 50;`
`374`	`375`	`sensor->status.saturation = 0;`
`375`	`376`	`sensor->status.sharpness = 0;`
`376`	`377`	`sensor->status.denoise = 0;`