Skip to content

Commit fda565a

Browse files
committed
Merge branch 'bugfix/partition_table_depends_esptoolpy' into 'master'
esptool_py: Fix issue where build with limited components doesn't include esptool_py Closes IDFGH-4876 and IDFGH-4874 See merge request espressif/esp-idf!12653
2 parents d44034c + 9c03f04 commit fda565a

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

components/app_update/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
idf_component_register(SRCS "esp_ota_ops.c"
22
"esp_app_desc.c"
33
INCLUDE_DIRS "include"
4-
REQUIRES spi_flash partition_table bootloader_support)
4+
REQUIRES spi_flash partition_table bootloader_support
5+
PRIV_REQUIRES esptool_py)
56

67
# esp_app_desc structure is added as an undefined symbol because otherwise the
78
# linker will ignore this structure as it has no other files depending on it.

components/bootloader/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
idf_component_register(PRIV_REQUIRES partition_table)
1+
idf_component_register(PRIV_REQUIRES partition_table esptool_py)
22

33
# Do not generate flash file when building bootloader or is in early expansion of the build
44
if(BOOTLOADER_BUILD OR NOT CONFIG_APP_BUILD_BOOTLOADER)

components/esp_wifi/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ idf_component_register(SRCS "src/coexist.c"
3535
"src/wifi_netif.c"
3636
"${idf_target}/esp_adapter.c"
3737
INCLUDE_DIRS "include" "${idf_target}/include"
38-
PRIV_REQUIRES wpa_supplicant nvs_flash esp_netif driver ${extra_priv_requires}
3938
REQUIRES esp_event
40-
PRIV_REQUIRES esp_timer esp_pm wpa_supplicant nvs_flash esp_netif ${extra_priv_requires}
39+
PRIV_REQUIRES driver esptool_py esp_netif esp_pm esp_timer nvs_flash
40+
wpa_supplicant ${extra_priv_requires}
4141
LDFRAGMENTS "${ldfragments}")
4242

4343
idf_build_get_property(build_dir BUILD_DIR)

components/partition_table/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
idf_component_register()
1+
idf_component_register(PRIV_REQUIRES esptool_py)
22

33
if(BOOTLOADER_BUILD)
44
return()

components/spiffs/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ idf_component_register(SRCS "esp_spiffs.c"
88
INCLUDE_DIRS "include"
99
PRIV_INCLUDE_DIRS "." "spiffs/src"
1010
REQUIRES spi_flash
11-
PRIV_REQUIRES bootloader_support)
11+
PRIV_REQUIRES bootloader_support esptool_py)
1212

1313
set_source_files_properties(spiffs/src/spiffs_nucleus.c PROPERTIES COMPILE_FLAGS -Wno-stringop-truncation)

0 commit comments

Comments
 (0)