Skip to content

Commit 98762ff

Browse files
committed
fix(events): FG: Always allow wifi events to host
Fixed the power save incorrect condition while setting Removed the C2 wifi only sdkconfig, as default also uses same values. Fix build issues for C2 and C3, to not include lwip hook file in building
1 parent 8bc3a4a commit 98762ff

File tree

10 files changed

+67
-193
lines changed

10 files changed

+67
-193
lines changed

esp_hosted_fg/esp/esp_driver/network_adapter/main/Kconfig.projbuild

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,7 @@ menu "Example Configuration"
638638

639639
choice "Wi-Fi control"
640640
prompt "Wi-Fi control"
641-
default BOTH_MANAGES_WIFI
641+
default SLAVE_MANAGES_WIFI
642642

643643
config SLAVE_MANAGES_WIFI
644644
bool "Slave manages Wi-Fi"

esp_hosted_fg/esp/esp_driver/network_adapter/main/slave_control.c

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,7 @@ void vTimerCallback( TimerHandle_t xTimer )
145145

146146
static void send_wifi_event_data_to_host(int event, void *event_data, int event_size)
147147
{
148-
#ifndef CONFIG_SLAVE_MANAGES_WIFI
149-
send_event_data_to_host(event, event_data, event_size);
150-
#endif
148+
send_event_data_to_host(event, event_data, event_size);
151149
}
152150

153151
static bool wifi_is_provisioned(wifi_config_t *wifi_cfg)
@@ -407,15 +405,13 @@ static void station_event_handler(void *arg, esp_event_base_t event_base,
407405
station_got_ip = 0;
408406
#endif
409407

410-
#ifndef CONFIG_SLAVE_MANAGES_WIFI
411-
wifi_event_sta_disconnected_t * disconnected_event =
412-
(wifi_event_sta_disconnected_t *) event_data;
408+
wifi_event_sta_disconnected_t * disconnected_event =
409+
(wifi_event_sta_disconnected_t *) event_data;
413410

414-
send_wifi_event_data_to_host(CTRL_MSG_ID__Event_StationDisconnectFromAP,
415-
disconnected_event, sizeof(wifi_event_sta_disconnected_t));
416-
ESP_LOGI(TAG, "Station disconnected, reason[%u]",
417-
disconnected_event->reason);
418-
#endif
411+
send_wifi_event_data_to_host(CTRL_MSG_ID__Event_StationDisconnectFromAP,
412+
disconnected_event, sizeof(wifi_event_sta_disconnected_t));
413+
ESP_LOGI(TAG, "Station disconnected, reason[%u]",
414+
disconnected_event->reason);
419415

420416
#ifdef CONFIG_NETWORK_SPLIT_ENABLED
421417
send_dhcp_dns_info_to_host(0, 0);
@@ -464,13 +460,12 @@ static void station_event_handler(void *arg, esp_event_base_t event_base,
464460
}
465461
sta_connect_retry = 0;
466462
prev_wifi_config_valid = true;
467-
#ifndef CONFIG_SLAVE_MANAGES_WIFI
468-
/* Event should not be triggered if event handler is
469-
* called as part of host triggered procedure like sta_disconnect etc
470-
**/
471-
send_wifi_event_data_to_host(CTRL_MSG_ID__Event_StationConnectedToAP,
472-
connected_event, sizeof(wifi_event_sta_connected_t));
473-
#endif
463+
464+
/* Event should not be triggered if event handler is
465+
* called as part of host triggered procedure like sta_disconnect etc
466+
**/
467+
send_wifi_event_data_to_host(CTRL_MSG_ID__Event_StationConnectedToAP,
468+
connected_event, sizeof(wifi_event_sta_connected_t));
474469

475470
memcpy(&lkg_sta_connected_event, connected_event, sizeof(wifi_event_sta_connected_t));
476471

esp_hosted_fg/esp/esp_driver/network_adapter/sdkconfig.defaults.esp32c2

Lines changed: 13 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ CONFIG_BT_ENABLED=n
88
CONFIG_BT_CONTROLLER_ONLY=y
99
CONFIG_BT_LE_SLEEP_ENABLE=y
1010

11-
# 3.1 BLE over SPI/SDIO
11+
# 2.1 BLE over SPI/SDIO
1212
#-----------------------
1313
CONFIG_BT_LE_HCI_INTERFACE_USE_RAM=y
1414

15-
# 3.2 BLE over UART
15+
# 2.2 BLE over UART
1616
#-------------------
1717
#UART pins, Enable below config, delete sdkconfig and rebuild
1818
#CONFIG_BT_LE_HCI_INTERFACE_USE_UART=y
@@ -21,43 +21,23 @@ CONFIG_BT_LE_HCI_INTERFACE_USE_RAM=y
2121
#CONFIG_BT_LE_HCI_UART_RX_PIN=18
2222

2323

24-
# 4. Partition Table
24+
# 3. Partition Table
2525
#--------------------
2626
CONFIG_PARTITION_TABLE_CUSTOM=y
2727
CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.esp32c2.csv"
2828

29-
# 5. Mempool
29+
# 4. Mempool
3030
#------------
3131
CONFIG_ESP_CACHE_MALLOC=y
3232

3333

34-
# 6.1 LWIP split
34+
# 5 LWIP split
3535
#---------------
3636

3737
CONFIG_NETWORK_SPLIT_ENABLED=n
38-
#CONFIG_LWIP_TCP_LOCAL_PORT_RANGE_START=61440
39-
#CONFIG_LWIP_TCP_LOCAL_PORT_RANGE_END=65535
40-
#CONFIG_LWIP_UDP_LOCAL_PORT_RANGE_START=61440
41-
#CONFIG_LWIP_UDP_LOCAL_PORT_RANGE_END=65535
4238

43-
#CONFIG_ESP_DEFAULT_LWIP_SLAVE=y
4439

45-
# 6.2 LWIP split examples
46-
#-------------------------
47-
CONFIG_ESP_HOSTED_COPROCESSOR_EXAMPLE_MQTT=n
48-
49-
50-
# 7. Transport config
51-
#---------------------
52-
# CONFIG_ESP_SDIO_NSEND_PSAMPLE=y
53-
# CONFIG_ESP_SDIO_DEFAULT_SPEED=y
54-
# CONFIG_ESP_SDIO_STREAMING_MODE=n
55-
56-
# For SPI Full duplex C6 on ESP32-P4-Function-EV-Board, please uncomment below
57-
#CONFIG_C6_SPI_WITH_P4=y
58-
59-
60-
# 8. Wifi config
40+
# 6. Wifi config
6141
#----------------
6242
#CONFIG_WIFI_CMD_BASIC_ONLY=y
6343

@@ -66,64 +46,44 @@ CONFIG_ESP_WIFI_DYNAMIC_RX_BUFFER_NUM=16
6646
CONFIG_ESP_WIFI_DYNAMIC_TX_BUFFER_NUM=16
6747
CONFIG_ESP_WIFI_AMPDU_TX_ENABLED=y
6848
CONFIG_ESP_WIFI_TX_BA_WIN=8
49+
#CONFIG_ESP_WIFI_TX_BA_WIN=16
6950
CONFIG_ESP_WIFI_AMPDU_RX_ENABLED=y
7051
CONFIG_ESP_WIFI_RX_BA_WIN=8
52+
#CONFIG_ESP_WIFI_RX_BA_WIN=14
7153

7254
CONFIG_ESP_WIFI_RX_IRAM_OPT=y
7355
CONFIG_ESP_WIFI_IRAM_OPT=y
7456

75-
# 9. LWIP config
76-
#----------------
77-
#CONFIG_LWIP_TCP_SND_BUF_DEFAULT=11520
78-
#CONFIG_LWIP_TCP_WND_DEFAULT=11520
79-
#CONFIG_LWIP_TCP_RECVMBOX_SIZE=16
80-
#CONFIG_LWIP_UDP_RECVMBOX_SIZE=16
81-
#CONFIG_LWIP_TCPIP_RECVMBOX_SIZE=32
82-
#CONFIG_LWIP_TCP_SACK_OUT=y
83-
#CONFIG_LWIP_TCPIP_CORE_LOCKING=y
84-
#CONFIG_LWIP_TCPIP_CORE_LOCKING_INPUT=y
85-
8657

87-
# 10. Optimizations
58+
# 7. Optimizations
8859
#-------------------
8960
CONFIG_COMPILER_OPTIMIZATION_SIZE=y
9061
#CONFIG_COMPILER_OPTIMIZATION_PERF=y
9162
CONFIG_ESPTOOLPY_FLASHMODE_QIO=y
92-
#CONFIG_ESPTOOLPY_FLASHFREQ_80M=y
9363

9464

95-
# 11. Stats
65+
# 8. Stats
9666
#-----------
97-
#CONFIG_ESP_HOSTED_FUNCTION_PROFILING=y
9867
CONFIG_ESP_PKT_STATS=y
9968

100-
# 12. Priorities
101-
#----------------
102-
#CONFIG_IPERF_TRAFFIC_TASK_PRIORITY=18
103-
#CONFIG_IPERF_REPORT_TASK_PRIORITY=18
104-
#CONFIG_ESP_DEFAULT_TASK_PRIO=18
105-
10669

107-
#13. Mem optimizations
70+
# 9. Mem optimizations
10871
#---------------------
10972
CONFIG_FREERTOS_PLACE_FUNCTIONS_INTO_FLASH=y
11073
CONFIG_ESP32_DEFAULT_CPU_FREQ_120=y
11174
CONFIG_ESP32_DEFAULT_CPU_FREQ_MHZ=120
11275
CONFIG_FREERTOS_UNICORE=y
11376

114-
#14. C2 specific opts
77+
#10. C2 specific opts
11578
#---------------------
11679
CONFIG_ESPTOOLPY_FLASHSIZE_4MB=n
11780
CONFIG_ESPTOOLPY_FLASHSIZE_2MB=y
11881

11982
CONFIG_ESP_DEFAULT_TASK_STACK_SIZE=2048
120-
#CONFIG_C2_C5_MODULE_SUB_BOARD=y
12183

122-
#15. C2 26 MHz XTAL chips
84+
#11. C2 26 MHz XTAL chips
12385
# C2 generally in MP has 26MHz.
12486
# If your C2 has 40MHz, just comment below lines
12587
#---------------------------------
12688
CONFIG_SOC_XTAL_SUPPORT_26M=y
12789
CONFIG_XTAL_FREQ_26=y
128-
129-

esp_hosted_fg/esp/esp_driver/network_adapter/sdkconfig.defaults.esp32c2.wifionly

Lines changed: 0 additions & 88 deletions
This file was deleted.

esp_hosted_fg/host/control_lib/src/ctrl_core.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1593,7 +1593,6 @@ int ctrl_app_send_req(ctrl_cmd_t *app_req)
15931593
CTRL_ALLOC_ASSIGN(CtrlMsgReqSetMode, req_set_power_save_mode);
15941594

15951595
if ((p->ps_mode < WIFI_PS_NONE) ||
1596-
(p->ps_mode < WIFI_PS_MIN_MODEM) ||
15971596
(p->ps_mode >= WIFI_PS_INVALID)) {
15981597
command_log("Invalid power save mode\n");
15991598
failure_status = CTRL_ERR_INCORRECT_ARG;

esp_hosted_fg/host/linux/host_control/python_support/commands_lib.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -182,17 +182,16 @@ def ctrl_app_event_callback(app_event):
182182

183183
if not is_network_split_on():
184184
print(" Network " + STA_INTERFACE + " is up. starting dhclient")
185-
nw_helper_func.run_dhclient_on_connected()
185+
nw_helper_func.run_dhcp_on_connected()
186186

187187

188188
elif app_event.contents.msg_id == CTRL_MSGID.CTRL_EVENT_STATION_DISCONNECT_FROM_AP.value:
189189
ssid = app_event.contents.control_data.e_sta_disconn.ssid
190-
print(" Station disconnected from AP: ssid[" + get_str(ssid) + "]")
190+
if not g_network_down_printed:
191+
print(" Station disconnected from AP: ssid[" + get_str(ssid) + "]")
192+
g_network_down_printed = True
191193

192194
if not is_network_split_on():
193-
if not g_network_down_printed:
194-
print(" Network " + STA_INTERFACE + " is down. stopping dhclient")
195-
g_network_down_printed = True
196195
nw_helper_func.stop_dhclient_on_disconnected()
197196

198197
nw_helper_func.down_sta_netdev();
@@ -250,7 +249,7 @@ def ctrl_app_event_callback(app_event):
250249
else:
251250
nw_helper_func.down_sta_netdev()
252251
if not g_network_down_printed:
253-
print("Network " + STA_INTERFACE + " brought down")
252+
print("Network " + STA_INTERFACE + " brought down!")
254253
g_network_down_printed = True
255254
else:
256255
print("MAC address invalid, skip DHCP/DNS event.")
@@ -1220,7 +1219,7 @@ def test_sync_set_wifi_power_save_mode(psmode):
12201219

12211220

12221221
def test_sync_set_wifi_power_save_mode_none():
1223-
return test_sync_set_wifi_power_save_mode(WIFI_PS_MODE.WIFI_PS_NONE_MODEM.value)
1222+
return test_sync_set_wifi_power_save_mode(WIFI_PS_MODE.WIFI_PS_NONE.value)
12241223

12251224

12261225
def test_sync_set_wifi_power_save_mode_max():

esp_hosted_fg/host/linux/host_control/python_support/hosted_py_header.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class WIFI_BW(Enum):
8989

9090

9191
class WIFI_PS_MODE(Enum):
92-
WIFI_PS_MODE_NONE = 0
92+
WIFI_PS_NONE = 0
9393
WIFI_PS_MIN_MODEM = 1
9494
WIFI_PS_MAX_MODEM = 2
9595
WIFI_PS_INVALID = 3

0 commit comments

Comments
 (0)