Skip to content

C3 + S3 Flash - CI test #6884

Closed
Closed
@P-R-O-C-H-Y

Description

@P-R-O-C-H-Y

Add flash testing to the GitHub CI. Following needs to be taken care of:

1st round:

  • Test files (sketch + test script)
    Add option for tests_build.sh to accept flash_mode parameter
    Add option to erase flash before uploading test to the chip
    Make sure to call the test for each chip for each flash mode

2nd round:

  • Add Flash r/w performance test

Activity

self-assigned this
on Jun 20, 2022
added this to the 2.0.4 milestone on Jun 20, 2022
added
Chip: ESP32-C3Issue is related to support of ESP32-C3 Chip
Chip: ESP32-S3Issue is related to support of ESP32-S3 Chip
on Jun 20, 2022
P-R-O-C-H-Y

P-R-O-C-H-Y commented on Jun 20, 2022

@P-R-O-C-H-Y
MemberAuthor

Adding @Ouss4, so we can discuss if needed here.

lbernstone

lbernstone commented on Jun 20, 2022

@lbernstone
Contributor

Maybe add a small r/w benchmark to keep an eye for any major issues that affect flash performance?

P-R-O-C-H-Y

P-R-O-C-H-Y commented on Jun 20, 2022

@P-R-O-C-H-Y
MemberAuthor

@lbernstone Good idea, we can add some test for r/w performance. Adding that to the list.

igrr

igrr commented on Jun 20, 2022

@igrr
Member

Just 2c, there is a benchmarking test for flash performance in several different mode in esp-idf CI. The problem is that it is extremely unreliable:

  • different flash chips of the same type may have varying erase times
  • erase times get significantly longer over the lifetime of the part (in CI the flash chips get a lot of wear)

Given that Arduino-esp32 pretty much directly calls the underlying IDF flash related functions, i think the likelihood of a performance regression is low, while the effort to maintain such a performance test would be relatively high.

me-no-dev

me-no-dev commented on Jun 20, 2022

@me-no-dev
Member

The one thing I see worth testing as speed is to make sure that there is actually a difference between the flash modes. With the latest findings (and until we fix this in the lib-builder) it seems to me that there is a chance that flash modes actually do not correspond to what is being set and enabled by the bootloader. @igrr do you thing that such test makes sense and will work, regradles of the flash chip differences?

added
Type: CI & TestingRelated to continuous integration, automated testing, or test infrastructure.
on Jun 27, 2022
moved this from In Progress to In Review in Arduino ESP32 Core Project Roadmapon Jun 29, 2022
removed this from the 2.0.4 milestone on Jul 11, 2022

3 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Chip: ESP32-C3Issue is related to support of ESP32-C3 ChipChip: ESP32-S3Issue is related to support of ESP32-S3 ChipType: CI & TestingRelated to continuous integration, automated testing, or test infrastructure.

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions

    C3 + S3 Flash - CI test · Issue #6884 · espressif/arduino-esp32