Skip to content

Arduino compiler string warnings when Preferences set to None #6118

Closed
@palmerr23

Description

@palmerr23

Board

DevkitC ESP32 WROOM

Device Description

DevkitC

Hardware Configuration

N/A

Version

latest master

IDE Name

Arduino

Operating System

Win 11

Flash frequency

80

PSRAM enabled

no

Upload speed

921600

Description

Frederic,

Even when Arduino compiler message Preferences are set to None, messages like the following appear:

warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
screenError("Bad EEPROM read\nFailed factory reset\nAborting", MY_RED, 10, false);

The message itself is not the issue (as it is correct), the problem is that it should not appear when compiler warnings are turned off.

Perhaps a compiler flag is not set correctly in the board file?

It's a minor issue, but it's annoying to have to hunt through all the warnings for an actual error!

BTW: thanks for the Arduino ESP32 implementation, it generally works pretty flawlessly.

Richard

Sketch

void screenError(char * message, uint16_t bgcol, uint16_t onTime, bool logo)

Debug Message

N/A

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

  • I confirm I have checked existing issues, online documentation and Troubleshooting guide.

Activity

VojtechBartoska

VojtechBartoska commented on Apr 11, 2022

@VojtechBartoska
Contributor

Hello, can you please retest this on v2.0.3-rc1?

palmerr23

palmerr23 commented on Apr 12, 2022

@palmerr23
Author

Issue is still present in v2.0.3-rc1

PilnyTomas

PilnyTomas commented on Apr 12, 2022

@PilnyTomas
Contributor

Hi @palmerr23, could you please provide complete sketch with all the #includes and other setup necessary to replicate your issue?

palmerr23

palmerr23 commented on Apr 13, 2022

@palmerr23
Author
void setup() {
badkitty("ABC");
}
void badkitty(char * msg){
}
void loop() {
}
![prefs](https://user-images.githubusercontent.com/14856369/163073937-8d8855b4-7710-4bbe-a002-1681e30ec1df.png)

C:\Users\xyzzy.DESKTOP-J4ESB3N\Documents\arduino\sketch_apr13a\sketch_apr13a.ino: In function 'void setup()':
C:\Users\xyzzy.DESKTOP-J4ESB3N\Documents\arduino\sketch_apr13a\sketch_apr13a.ino:2:11: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
badkitty("ABC");

Arduino 1.8.19 with v2.0.3-rc1

Preferences image attached.

moved this from Todo to Under investigation in Arduino ESP32 Core Project Roadmapon Apr 13, 2022

11 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Arduino compiler string warnings when Preferences set to None · Issue #6118 · espressif/arduino-esp32