You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the http client gets multible headers with the same name in the response (for example set-cookie headers), they get overwritten. My way to fix it was to change
I just took a quick review of the code. I am not in favor of this change:
It does not fix the underlying problem: only one header with a specific name can exists, while a server may send more than one
It only changes the behavior from keeping the last header sent with a certain name to keeping the first with a certain name
A real solution would involve quite some adaptations and very likely an API change, since requestArgument (not a very good name because in this context it is used as a responseArgument) needs to accommodate an array or vector of values. This implies changes in the functions for accessing the values as well.
[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
Activity
lbernstone commentedon Jun 7, 2020
Make an edit right at that page and in the pull request mention @Jeroen88
Jeroen88 commentedon Jun 8, 2020
I just took a quick review of the code. I am not in favor of this change:
A real solution would involve quite some adaptations and very likely an API change, since requestArgument (not a very good name because in this context it is used as a responseArgument) needs to accommodate an array or vector of values. This implies changes in the functions for accessing the values as well.
stale commentedon Aug 7, 2020
[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
kurenai-ryu commentedon Aug 11, 2020
why not implement like on the esp8266?
https://github.com/esp8266/Arduino/blob/6feda9ebda8d5588c288145bff2f9f0d816b3ec2/libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp#L1277
stale commentedon Aug 11, 2020
[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.
stale commentedon Oct 10, 2020
[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
stale commentedon Oct 24, 2020
[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.
HttpClient: Add cookie support (cookie jar) (#6216)
Cookie jar (#71)