Multible http response headers with the same name get overwritten

[jonasniesner]

If the http client gets multible headers with the same name in the response (for example set-cookie headers), they get overwritten. My way to fix it was to change

arduino-esp32/libraries/HTTPClient/src/HTTPClient.cpp

Line 1149 in b92c58d

if(_currentHeaders[i].key.equalsIgnoreCase(headerName)) {

to

if(_currentHeaders[i].key.equalsIgnoreCase(headerName) && _currentHeaders[i].value.length() == 0) {

to check if the header value is not set to avoid overwriting when saving multible headers with the same name

[lbernstone]

Make an edit right at that page and in the pull request mention @Jeroen88

[Jeroen88]

I just took a quick review of the code. I am not in favor of this change:

• It does not fix the underlying problem: only one header with a specific name can exists, while a server may send more than one
• It only changes the behavior from keeping the last header sent with a certain name to keeping the first with a certain name

A real solution would involve quite some adaptations and very likely an API change, since requestArgument (not a very good name because in this context it is used as a responseArgument) needs to accommodate an array or vector of values. This implies changes in the functions for accessing the values as well.

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[kurenai-ryu]

why not implement like on the esp8266?
https://github.com/esp8266/Arduino/blob/6feda9ebda8d5588c288145bff2f9f0d816b3ec2/libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp#L1277

[stale]

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[stale]

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.