-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Closed
Labels
Type: CI & TestingRelated to continuous integration, automated testing, or test infrastructure.Related to continuous integration, automated testing, or test infrastructure.Type: DocumentationIssue pertains to Documentation of Arduino ESP32Issue pertains to Documentation of Arduino ESP32
Description
Description
Hello,
I am preparing a PR to contribute middleware support (aka Expressif) to WebServer, plus some examples and middleware implementations (cors, security, logging).
I didn't find any guidelines explaining the process to compile our changes and test the examples we write on a real board before submitting the PR.
Right now, I work around that by adding some platformio.ini files and using PIO to build the examples, but this is quite a hack.
What contributors should do to locally test and run the examples we write against the modifications we did ?
Thanks :-)
I have checked existing issues, online documentation and the Troubleshooting Guide
- I confirm I have checked existing issues, online documentation and Troubleshooting guide.To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Metadata
Metadata
Assignees
Labels
Type: CI & TestingRelated to continuous integration, automated testing, or test infrastructure.Related to continuous integration, automated testing, or test infrastructure.Type: DocumentationIssue pertains to Documentation of Arduino ESP32Issue pertains to Documentation of Arduino ESP32
Activity
me-no-dev commentedon Aug 16, 2024
@lucasssvaz @P-R-O-C-H-Y any way this can be tested with wokwi?
Jason2866 commentedon Aug 16, 2024
@mathieucarbou Thx, for bringing this up. After the big refactoring of the GH Actions (btw. great work imho) i do not manage to test my changes anymore before opening a PR ;-)
mathieucarbou commentedon Aug 16, 2024
I've tried running
github/scripts/on-push.sh
locally, it succeeded, which proves it didn't consider my changes... 🤣So right now I am "working" with this simple pio file put inside
libraries/WebServer
: