Test static code analyzer

Author: lucasssvaz

.github/scripts/install-arduino-cli.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-OSBITS=`arch`
+OSBITS=`uname -m`
 if [[ "$OSTYPE" == "linux"* ]]; then
     export OS_IS_LINUX="1"
     if [[ "$OSBITS" == "i686" ]]; then

.github/scripts/on-push.sh

@@ -2,8 +2,6 @@
 
 set -e
 
-export ARDUINO_BUILD_DIR="$HOME/.arduino/build.tmp"
-
 function build(){
     local target=$1
     local fqbn=$2

.github/scripts/sketch_utils.sh

@@ -131,13 +131,13 @@ function build_sketch(){ # build_sketch <ide_path> <user_path> <path-to-ino> [ex
         echo "Skipping $sketchname for target $target"
         exit 0
     fi
-    
+
     ARDUINO_CACHE_DIR="$HOME/.arduino/cache.tmp"
     if [ -n "$ARDUINO_BUILD_DIR" ]; then
         build_dir="$ARDUINO_BUILD_DIR"
     elif [ $len -eq 1 ]; then
         # build_dir="$sketchdir/build"
-        build_dir="$HOME/.arduino/tests/$sketchname/build.tmp"
+        build_dir="$HOME/.arduino/tests/$sketchname/build.tmp/$target"
     fi
 
     mkdir -p "$ARDUINO_CACHE_DIR"
@@ -165,7 +165,7 @@ function build_sketch(){ # build_sketch <ide_path> <user_path> <path-to-ino> [ex
                 --build-cache-path "$ARDUINO_CACHE_DIR" \
                 --build-path "$build_dir" \
                 $xtra_opts "${sketchdir}"
-            
+
             exit_status=$?
             if [ $exit_status -ne 0 ]; then
                 echo ""ERROR: Compilation failed with error code $exit_status""

.github/workflows/pre-commit.yml

@@ -4,11 +4,14 @@ on:
   pull_request:
     types: [opened, reopened, synchronize, labeled]
 
+concurrency:
+  group: pre-commit-${{github.event.pull_request.number || github.ref}}
+  cancel-in-progress: true
+
 jobs:
   lint:
-    if: |
-      contains(github.event.pull_request.labels.*.name, 'Status: Pending Merge')
-    name: Checking if any fixes are needed
+    #if: ${{ contains(github.event.pull_request.labels.*.name, 'Status: Pending Merge') }}
+    name: Run pre-commit hooks
     runs-on: ubuntu-latest
     steps:
       - name: Checkout latest commit
@@ -35,9 +38,49 @@ jobs:
             ~/.cache/pip
           key: pre-commit|${{ env.PY_HASH }}|${{ hashFiles('.pre-commit-config.yaml', '.github/workflows/pre-commit.yml') }}
 
+      - name: Install apt dependencies
+        uses: awalsh128/cache-apt-pkgs-action@latest
+        with:
+          packages: cppcheck
+          version: 1.0
+
       - name: Install python dependencies
         run: python -m pip install pre-commit docutils
 
+      # - name: Wait on other jobs to finish
+      #   uses: lucasssvaz/wait-on-workflow@v1
+      #   id: wait-on-jobs
+      #   continue-on-error: true
+      #   with:
+      #     workflow: push.yml
+      #     max-wait: 5
+      #     interval: 30
+      #     timeout: 120
+      #     sha: ${{ github.event.pull_request.head.sha || github.sha }}
+
+      - name: Download compilation artifacts
+        uses: actions/download-artifact@v4
+        # if: ${{ steps.wait-on-jobs.outputs.run-id != '' }}
+        with:
+          pattern: build-job-*
+          merge-multiple: true
+          path: ~/.arduino/tests/
+          # run-id: ${{ steps.wait-on-jobs.outputs.run-id }}
+          run-id: 8674717774
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Merge compile commands
+        # if: ${{ steps.wait-on-jobs.outputs.run-id != '' }}
+        run: |
+          find ~/.arduino/tests/ -iname "compile_commands.json" | xargs jq -s 'map(.[])' > ~/compile_commands.json
+
+      - name: Upload compile commands
+        # if: ${{ steps.wait-on-jobs.outputs.run-id != '' }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: compile_commands
+          path: ~/compile_commands.json
+
       - name: Get changed files
         id: changed-files
         uses: tj-actions/[email protected]
@@ -58,3 +101,5 @@ jobs:
       - name: Push changes using pre-commit-ci-lite
         uses: pre-commit-ci/[email protected]
         if: always()
+        with:
+          msg: "ci(pre-commit): Apply automatic fixes"

.github/workflows/push.yml

@@ -48,6 +48,17 @@ jobs:
     - name: Build Sketches
       run: bash ./.github/scripts/on-push.sh ${{ matrix.chunk }} 15
 
+    - name: Upload artifact
+      uses: actions/upload-artifact@v4
+      with:
+        name: build-job-${{ matrix.chunk }}
+        path: |
+          ~/.arduino/tests/**/*.h
+          ~/.arduino/tests/**/*.cpp
+          ~/.arduino/tests/**/*.bin
+          ~/.arduino/tests/**/compile_commands.json
+        if-no-files-found: error
+
   # Windows and MacOS
   build-arduino-win-mac:
     name: Arduino on ${{ matrix.os }}

.pre-commit-config.yaml

@@ -30,6 +30,12 @@ repos:
     hooks:
       - id: clang-format
         types_or: [c, c++]
+  - repo: https://github.com/pocc/pre-commit-hooks
+    rev: "v1.3.5"
+    hooks:
+      - id: cppcheck
+        types_or: [c, c++]
+        args: [--force, --enable=all, --suppress=missingInclude, --inline-suppr, --inconclusive]
   - repo: https://github.com/psf/black-pre-commit-mirror
     rev: "22.10.0"
     hooks:

cores/esp32/HEXBuilder.cpp

@@ -14,7 +14,7 @@
 
   You should have received a copy of the GNU Lesser General Public
   License along with this library; if not, write to the Free Software
-  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USAa
 */
 
 #include <Arduino.h>