Improve RGB LED Driver

Replaces the use of the `LED_BUILTIN` variable by creating a new variable called `RGB_BUILTIN`. On boards with both a regular LED and RGB LED, this change provides functionality to control either LED.

The `LED_BRIGHTNESS` variable is changed to `RGB_BRIGHTNESS`, which aligns more closely with the `RGB_BUILTIN` variable name.

`BOARD_HAS_NEOPIXEL` is no longer necessary; it is replaced by `RGB_BUILTIN`.

Author: santaimpersonator

cores/esp32/esp32-hal-gpio.c

@@ -91,9 +91,9 @@ static InterruptHandle_t __pinInterruptHandlers[SOC_GPIO_PIN_COUNT] = {0,};
 
 extern void ARDUINO_ISR_ATTR __pinMode(uint8_t pin, uint8_t mode)
 {
-#ifdef BOARD_HAS_NEOPIXEL
-    if (pin == LED_BUILTIN){
-        __pinMode(LED_BUILTIN-SOC_GPIO_PIN_COUNT, mode);
+#ifdef RGB_BUILTIN
+    if (pin == RGB_BUILTIN){
+        __pinMode(RGB_BUILTIN-SOC_GPIO_PIN_COUNT, mode);
         return;
     }
 #endif
@@ -134,11 +134,11 @@ extern void ARDUINO_ISR_ATTR __pinMode(uint8_t pin, uint8_t mode)
 
 extern void ARDUINO_ISR_ATTR __digitalWrite(uint8_t pin, uint8_t val)
 {
-    #ifdef BOARD_HAS_NEOPIXEL
-        if(pin == LED_BUILTIN){
+    #ifdef RGB_BUILTIN
+        if(pin == RGB_BUILTIN){
             //use RMT to set all channels on/off
-            const uint8_t comm_val = val != 0 ? LED_BRIGHTNESS : 0;
-            neopixelWrite(LED_BUILTIN, comm_val, comm_val, comm_val);
+            const uint8_t comm_val = val != 0 ? RGB_BRIGHTNESS : 0;
+            neopixelWrite(RGB_BUILTIN, comm_val, comm_val, comm_val);
             return;
         }
     #endif

cores/esp32/esp32-hal-rgb-led.c

@@ -7,9 +7,9 @@ void neopixelWrite(uint8_t pin, uint8_t red_val, uint8_t green_val, uint8_t blue
   static bool initialized = false;
 
   uint8_t _pin = pin;
-#ifdef BOARD_HAS_NEOPIXEL
-  if(pin == LED_BUILTIN){
-    _pin = LED_BUILTIN-SOC_GPIO_PIN_COUNT;
+#ifdef RGB_BUILTIN
+  if(pin == RGB_BUILTIN){
+    _pin = RGB_BUILTIN-SOC_GPIO_PIN_COUNT;
   }
 #endif
 

cores/esp32/esp32-hal-rgb-led.h

@@ -7,8 +7,8 @@ extern "C" {
 
 #include "esp32-hal.h"
 
-#ifndef LED_BRIGHTNESS
-  #define LED_BRIGHTNESS 64
+#ifndef RGB_BRIGHTNESS
+  #define RGB_BRIGHTNESS 64
 #endif
 
 void neopixelWrite(uint8_t pin, uint8_t red_val, uint8_t green_val, uint8_t blue_val);