Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>

Author: P-R-O-C-H-Y

libraries/Zigbee/examples/Zigbee_Binary_Input/Zigbee_Binary_Input.ino

@@ -13,17 +13,16 @@
 // limitations under the License.
 
 /**
- * @brief This example demonstrates Zigbee analog input / output device.
+ * @brief This example demonstrates Zigbee binary input device.
  *
- * The example demonstrates how to use Zigbee library to create a end device analog device.
+ * The example demonstrates how to use Zigbee library to create an end device binary sensor device.
  *
  * Proper Zigbee mode must be selected in Tools->Zigbee mode
  * and also the correct partition scheme must be selected in Tools->Partition Scheme.
  *
  * Please check the README.md for instructions and more detailed description.
  *
  * Created by Jan Procházka (https://github.com/P-R-O-C-H-Y/)
- * Modified by Pat Clay
  */
 
 #ifndef ZIGBEE_MODE_ED
@@ -32,7 +31,7 @@
 
 #include "Zigbee.h"
 
-/* Zigbee analog device configuration */
+/* Zigbee binary sensor device configuration */
 #define BINARY_DEVICE_ENDPOINT_NUMBER 1
 
 uint8_t binaryPin = A0;
@@ -43,10 +42,6 @@ ZigbeeBinary zbBinaryZone = ZigbeeBinary(BINARY_DEVICE_ENDPOINT_NUMBER + 1);
 
 bool binaryStatus = false;
 
-void onAnalogOutputChange(float analog_output) {
-  Serial.printf("Received analog output change: %.1f\r\n", analog_output);
-}
-
 void setup() {
   Serial.begin(115200);
   Serial.println("Starting...");
@@ -89,10 +84,6 @@ void setup() {
     delay(100);
   }
   Serial.println("Connected");
-
-  // // Optional: Add reporting for analog input
-  // zbBinaryFan.setBinaryInputReporting(0, 30, 10);  // report every 30 seconds if value changes by 10
-  // zbBinaryZone.setBinaryInputReporting(0, 30, 10);  // report every 30 seconds if value changes by 10
 }
 
 void loop() {

libraries/Zigbee/src/ep/ZigbeeBinary.cpp

@@ -58,7 +58,7 @@ bool ZigbeeBinary::setBinaryInputApplication(uint32_t application_type) {
     esp_zb_cluster_list_get_cluster(_cluster_list, ESP_ZB_ZCL_CLUSTER_ID_BINARY_INPUT, ESP_ZB_ZCL_CLUSTER_SERVER_ROLE);
   esp_err_t ret = esp_zb_cluster_update_attr(binary_input_cluster, ESP_ZB_ZCL_ATTR_BINARY_INPUT_APPLICATION_TYPE_ID, (void *)&application_type_value);
   if (ret != ESP_OK) {
-    log_e("Failed to set AI application type: 0x%x: %s", ret, esp_err_to_name(ret));
+    log_e("Failed to set Binary Input application type: 0x%x: %s", ret, esp_err_to_name(ret));
     return false;
   }
   return true;

libraries/Zigbee/src/ep/ZigbeeBinary.h

@@ -1,4 +1,4 @@
-/* Class of Zigbee Analog sensor endpoint inherited from common EP class */
+/* Class of Zigbee Binary sensor endpoint inherited from common EP class */
 
 #pragma once