-
Notifications
You must be signed in to change notification settings - Fork 70
Change Request: Stop rolling up package #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'll look into this if there is consensus within the team. |
I believe this issue aligns with the one I’ve been working on: #367. While the combination of If this is accepted, it will make the ongoing migration to the So, 👍 to this! Let’s move forward. But one thing I’m afraid of is: wouldn’t this be a breaking change? |
I don't think so. What is it you think would break? |
I'm just wondering — If we remove Does the automatically generated |
When doing this with For a package user, this change is transparent. |
Thank you for the explanation. In that case, I suppose there won’t be any issues if we stop bundling the packages. 👍 |
Sounds good to remove the Rollup bundling step to simplify the build process. +1 from me. |
Sounds good to me too 👍 |
Marking this as accepted. @xbinaryx Would you like to send a PR? |
Environment
HEAD
What problem do you want to solve?
Right now, we're rolling up the files in this package for distribution, we requires us cleaning up duplicate type definitions. This is a lot of work and we're stuck with how we can reference types between files due to these limitations.
What do you think is the correct solution?
Stop rolling up the package. This isn't strictly necessary because it's an ESM-only package, and therefore, we're not getting much extra value from rolling things up.
We can remove Rollup and just have
tsc
emit both types and code to thedist
directory. The end result for plugin users will be the same and it will allow us more flexibility with how we import and define types.Participation
Additional comments
No response
The text was updated successfully, but these errors were encountered: