fix!: remove rollup, extraneous types and migrate to ESM-only (#197)

* fix!: remove `rollup`, extraneous types and migrate to ESM-only

* wip

* wip

* wip: arethetypeswrong

* wip: convention

Author: lumirlumir

.github/workflows/ci.yml

@@ -56,6 +56,19 @@ jobs:
               run: npm install
             - name: Check Types
               run: npm run test:types
+    are_the_types_wrong:
+        name: Are the types wrong?
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v6
+            - name: Setup Node.js
+              uses: actions/setup-node@v6
+              with:
+                  node-version: "lts/*"
+            - name: Install Packages
+              run: npm install
+            - name: Check validity of type definitions
+              run: npm run lint:types
     jsr_test:
         name: Verify JSR Publish
         runs-on: ubuntu-latest

jsr.json

@@ -1,12 +1,10 @@
 {
   "name": "@eslint/json",
   "version": "0.14.0",
-  "exports": "./dist/esm/index.js",
+  "exports": "./dist/index.js",
   "publish": {
     "include": [
-      "dist/esm/index.js",
-      "dist/esm/index.d.ts",
-      "dist/esm/types.ts",
+      "dist",
       "README.md",
       "jsr.json",
       "LICENSE"

package.json

@@ -4,26 +4,15 @@
   "description": "JSON linting plugin for ESLint",
   "author": "Nicholas C. Zakas",
   "type": "module",
-  "main": "dist/esm/index.js",
-  "types": "dist/esm/index.d.ts",
+  "main": "dist/index.js",
+  "types": "dist/index.d.ts",
   "exports": {
     ".": {
-      "require": {
-        "types": "./dist/cjs/index.d.cts",
-        "default": "./dist/cjs/index.cjs"
-      },
-      "import": {
-        "types": "./dist/esm/index.d.ts",
-        "default": "./dist/esm/index.js"
-      }
+      "types": "./dist/index.d.ts",
+      "default": "./dist/index.js"
     },
     "./types": {
-      "require": {
-        "types": "./dist/cjs/types.cts"
-      },
-      "import": {
-        "types": "./dist/esm/types.d.ts"
-      }
+      "types": "./dist/types.d.ts"
     }
   },
   "files": [
@@ -41,10 +30,7 @@
       "prettier --write"
     ],
     "!(*.js)": "prettier --write --ignore-unknown",
-    "README.md": [
-      "npm run build:update-rules-docs"
-    ],
-    "{src/rules/*.js,tools/update-rules-docs.js}": [
+    "{src/rules/*.js,tools/update-rules-docs.js,README.md}": [
       "npm run build:update-rules-docs",
       "git add README.md"
     ]
@@ -58,20 +44,20 @@
   },
   "homepage": "https://github.com/eslint/json#readme",
   "scripts": {
-    "build:dedupe-types": "node tools/dedupe-types.js dist/cjs/index.cjs dist/esm/index.js",
-    "build:cts": "node tools/build-cts.js",
+    "build": "npm run build:rules && npm run build:types && npm run build:update-rules-docs",
     "build:rules": "node tools/build-rules.js",
-    "build": "npm run build:rules && rollup -c && npm run build:dedupe-types && tsc -p tsconfig.esm.json && npm run build:cts",
+    "build:types": "tsc",
     "build:update-rules-docs": "node tools/update-rules-docs.js",
     "prepare": "npm run build",
     "pretest": "npm run build",
     "lint": "eslint",
     "lint:fix": "eslint --fix",
+    "lint:types": "attw --pack --profile esm-only",
     "fmt": "prettier --write .",
     "fmt:check": "prettier --check .",
     "test": "mocha \"tests/**/*.test.js\"",
     "test:coverage": "c8 npm test",
-    "test:jsr": "npx jsr@latest publish --dry-run",
+    "test:jsr": "npx -y jsr@latest publish --dry-run",
     "test:types": "tsc -p tests/types/tsconfig.json"
   },
   "keywords": [
@@ -89,6 +75,7 @@
     "natural-compare": "^1.4.0"
   },
   "devDependencies": {
+    "@arethetypeswrong/cli": "^0.18.2",
     "c8": "^10.1.3",
     "dedent": "^1.5.3",
     "eslint": "^9.39.2",
@@ -99,9 +86,6 @@
     "mdast-util-from-markdown": "^2.0.2",
     "mocha": "^11.3.0",
     "prettier": "^3.4.1",
-    "rollup": "^4.52.3",
-    "rollup-plugin-copy": "^3.5.0",
-    "rollup-plugin-delete": "^3.0.1",
     "typescript": "^5.9.2",
     "yorkie": "^2.0.0"
   },

rollup.config.js

@@ -22,7 +22,7 @@ import {
 /**
  * @import { DocumentNode, AnyNode, Token, LocationRange } from "@humanwhocodes/momoa";
  * @import { FileProblem, DirectiveType, RulesConfig } from "@eslint/core";
- * @import { JSONSyntaxElement } from "../types.ts";
+ * @import { JSONSyntaxElement } from "../types.js";
  * @import { JSONLanguageOptions } from "./json-language.js";
  */
 

src/languages/json-source-code.js

@@ -15,7 +15,7 @@ import { getKey, getRawKey } from "../util.js";
 
 /**
  * @import { MemberNode } from "@humanwhocodes/momoa";
- * @import { JSONRuleDefinition } from "../types.ts";
+ * @import { JSONRuleDefinition } from "../types.js";
  * @typedef {"duplicateKey"} NoDuplicateKeysMessageIds
  * @typedef {JSONRuleDefinition<{ MessageIds: NoDuplicateKeysMessageIds }>} NoDuplicateKeysRuleDefinition
  */

src/rules/no-duplicate-keys.js

@@ -14,7 +14,7 @@ import { getKey } from "../util.js";
 //-----------------------------------------------------------------------------
 
 /**
- * @import { JSONRuleDefinition } from "../types.ts";
+ * @import { JSONRuleDefinition } from "../types.js";
  * @typedef {"emptyKey"} NoEmptyKeysMessageIds
  * @typedef {JSONRuleDefinition<{ MessageIds: NoEmptyKeysMessageIds }>} NoEmptyKeysRuleDefinition
  */

src/rules/no-empty-keys.js

@@ -14,7 +14,7 @@ import { getKey } from "../util.js";
 //-----------------------------------------------------------------------------
 
 /**
- * @import { JSONRuleDefinition } from "../types.ts";
+ * @import { JSONRuleDefinition } from "../types.js";
  * @typedef {"unnormalizedKey"} NoUnnormalizedKeysMessageIds
  * @typedef {{ form: string }} NoUnnormalizedKeysOptions
  * @typedef {JSONRuleDefinition<{ RuleOptions: [NoUnnormalizedKeysOptions], MessageIds: NoUnnormalizedKeysMessageIds }>} NoUnnormalizedKeysRuleDefinition

src/rules/no-unnormalized-keys.js

@@ -8,7 +8,7 @@
 //-----------------------------------------------------------------------------
 
 /**
- * @import { JSONRuleDefinition } from "../types.ts";
+ * @import { JSONRuleDefinition } from "../types.js";
  * @typedef {"unsafeNumber"|"unsafeInteger"|"unsafeZero"|"subnormal"|"loneSurrogate"} NoUnsafeValuesMessageIds
  * @typedef {JSONRuleDefinition<{ MessageIds: NoUnsafeValuesMessageIds }>} NoUnsafeValuesRuleDefinition
  */

src/rules/no-unsafe-values.js

@@ -16,7 +16,7 @@ import { getKey, getRawKey } from "../util.js";
 //-----------------------------------------------------------------------------
 
 /**
- * @import { JSONRuleDefinition } from "../types.ts";
+ * @import { JSONRuleDefinition } from "../types.js";
  * @import { MemberNode } from "@humanwhocodes/momoa";
  * @typedef {Object} SortOptions
  * @property {boolean} caseSensitive Whether key comparisons are case-sensitive.