fix: object type checks

Author: sijis

errbot/botplugin.py

@@ -44,7 +44,7 @@ def recurse_check_structure(sample: Any, to_check: Any) -> None:
             recurse_check_structure(sample[0], element)
         return
 
-    if sample_type == dict:
+    if sample_type == dict: # noqa: E721
         for key in sample:
             if key not in to_check:
                 raise ValidationException(f"{to_check} doesn't contain the key {key}.")

errbot/core_plugins/plugins.py

@@ -187,7 +187,7 @@ def plugin_config(self, _, args):
         except Exception:
             self.log.exception("Invalid expression for the configuration of the plugin")
             return "Syntax error in the given configuration"
-        if type(real_config_obj) != type(template_obj):
+        if type(real_config_obj) is not type(template_obj):
             return "It looks fishy, your config type is not the same as the template!"
 
         self._bot.plugin_manager.set_plugin_configuration(plugin_name, real_config_obj)

tools/plugin-gen.py

@@ -187,7 +187,7 @@ def check_repo(repo):
             repo_entry[name] = plugin
             plugins[repo_name] = repo_entry
             log.debug("Catalog added plugin %s.", plugin["name"])
-        except:
+        except Exception:
             log.error("Invalid syntax in %s, skipping...", plug["path"])
             continue