Privatise compiler options.

Author: enetheru

cmake/common_compiler_flags.cmake

@@ -48,7 +48,7 @@ function( common_compiler_flags )
 
     # These compiler options reflect what is in godot/SConstruct.
     target_compile_options( ${TARGET_NAME}
-        PUBLIC
+        PRIVATE
             # Disable exception handling. Godot doesn't use exceptions anywhere, and this
             # saves around 20% of binary size and very significant build time.
             $<${DISABLE_EXCEPTIONS}:
@@ -90,8 +90,6 @@ function( common_compiler_flags )
             /wd4514  # C4514 (unreferenced inline function has been removed)
             /wd4714  # C4714 (function marked as __forceinline not inlined)
             /wd4820  # C4820 (padding added after construct)
-
-            /utf-8
         >
 
         # Clang and GNU common options
@@ -153,7 +151,7 @@ function( common_compiler_flags )
     )
 
     target_link_options( ${TARGET_NAME}
-        PUBLIC
+        PRIVATE
             $<${IS_MSVC}:
                 /WX             # treat link warnings as errors.
                 /MANIFEST:NO    # We dont need a manifest

test/CMakeLists.txt

@@ -20,6 +20,13 @@ target_link_libraries( godot-cpp-test
         PRIVATE
         godot-cpp::${TEST_TARGET} )
 
+# These compiler options reflect what is in godot/SConstruct.
+target_compile_options( godot-cpp-test
+        PRIVATE
+        # Interpret source code files using utf8
+        $<${IS_MSVC}:/utf-8>
+)
+
 ### Get useful properties of the library
 get_target_property( GODOT_PLATFORM godot-cpp::${TEST_TARGET} GODOT_PLATFORM )
 get_target_property( GODOT_TARGET godot-cpp::${TEST_TARGET} GODOT_TARGET )