Simplify MODULARIZE code to always use async factory function #24727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs here were wrong. We have the `addRunDependency` system that can delay module's readiness for an arbitrary amount of time, even if async compilation is disabled. This `addRunDependency` system does not exist in MINUMAL_RUTTIME, so in some cases we can avoid the ready promise in MINIMAL_RUNTIME mode, but that is a pretty subtle distinction that only applies to MINIMAL_RUNTIME. Also even in this mode we were still marking the factory function as async (note the lack of USE_READY_PROMISE in the existing condition).
sbc100
force-pushed
the
simplify_modularize
branch
from
a18ff2d to
d61be25
Compare
kripken
approved these changes
Jul 16, 2025
| (If WASM_ASYNC_COMPILATION is off, that is, if compilation is | ||
| *synchronous*, then it would not make sense to return a Promise, and instead | ||
| the Module object itself is returned, which is ready to be used.) | ||
| the code wrapped in an async function. This functions returns a promise that |
There was a problem hiding this comment.
Suggested change
| the code wrapped in an async function. This functions returns a promise that | |
| the code wrapped in an async function. This function returns a promise that |
| *synchronous*, then it would not make sense to return a Promise, and instead | ||
| the Module object itself is returned, which is ready to be used.) | ||
| the code wrapped in an async function. This functions returns a promise that | ||
| resolves to a module instance when once it is safe to run the compiled code |
There was a problem hiding this comment.
Suggested change
| resolves to a module instance when once it is safe to run the compiled code | |
| resolves to a module instance when it is safe to run the compiled code |
There was a problem hiding this comment.
(could also be "once", but not "when once" together, I think)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs here were wrong. We have the
addRunDependencysystem that can delay module's readiness for an arbitrary amount of time, even if async compilation is disabled.This
addRunDependencysystem does not exist inMINUMAL_RUTTIME, so in some cases we can avoid the ready promise inMINIMAL_RUNTIMEmode, but that is a pretty subtle distinction that only applies toMINIMAL_RUNTIME. Also even in this mode we were still marking the factory function as async (note the lack ofUSE_READY_PROMISEin the existing condition).