Skip to content

Commit d4bdb53

Browse files
authored
Skip tests that fail on Windows. (#24435)
These tests are not in a good shape on Windows, or assume Linux/macOS behavior. Something that I might be able to look into later, but for now want to focus on getting a passing test run on a Windows system.
1 parent d8d3280 commit d4bdb53

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

test/test_core.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6130,6 +6130,7 @@ def test_unistd_links(self):
61306130
self.do_run_in_out_file_test('unistd/links.c')
61316131

61326132
@also_with_noderawfs
6133+
@no_windows('TODO: Fails on Windows due to an unknown reason.')
61336134
def test_unistd_write_broken_link(self):
61346135
self.do_run_in_out_file_test('unistd/test_unistd_write_broken_link.c')
61356136

@@ -8270,6 +8271,7 @@ def test_asyncify_unused(self):
82708271
'onlylist_b_response': ([], True, 'main\n__original_main\nfoo(int, double)\nbaz()\nc_baz\nStructy::funcy()\n'),
82718272
'onlylist_c_response': ([], False, 'main\n__original_main\nfoo(int, double)\nbaz()\nc_baz\n'),
82728273
})
8274+
@no_windows("TODO: Fails on Windows due to an unknown reason.")
82738275
def test_asyncify_lists(self, args, should_pass, response=None):
82748276
if response is not None:
82758277
create_file('response.file', response)

test/test_other.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -825,6 +825,7 @@ def test_em_config_filename(self):
825825
self.assertContained('LLVM', proc.stdout)
826826
self.assertContained('filename myconfig.py', proc.stdout)
827827

828+
@no_windows('This test depends on Linux line endings')
828829
def test_emsize(self):
829830
# test binaryen generated by running:
830831
# emcc test/hello_world.c -Oz --closure 1 -o test/other/test_emsize.js
@@ -1758,6 +1759,7 @@ def test_ungetc_fscanf(self):
17581759
self.emcc('main.c', ['--embed-file', 'my_test.input'], output_filename='a.out.js')
17591760
self.assertContained('zyx', self.run_process(config.JS_ENGINES[0] + ['a.out.js'], stdout=PIPE, stderr=PIPE).stdout)
17601761

1762+
@no_windows('This test is written to work on Linux and macOS only')
17611763
def test_abspaths(self):
17621764
# Includes with absolute paths are generally dangerous, things like -I/usr/.. will get to system
17631765
# local headers, not our portable ones.

0 commit comments

Comments
 (0)