Minify whitespace in modularization code (#24536)

Author: sbc100

test/other/codesize/test_codesize_minimal_esm.gzsize

@@ -1 +1 @@
-1263
+1236

test/other/codesize/test_codesize_minimal_esm.jssize

@@ -1 +1 @@
-2588
+2556

tools/building.py

@@ -618,6 +618,13 @@ def closure_compiler(filename, advanced=True, extra_closure_args=None):
   if settings.DEBUG_LEVEL > 1:
     args += ['--debug']
 
+  # Now that we have run closure compiler once, we have stripped all the closure compiler
+  # annotations from the source code and we no longer need to worry about generating closure
+  # friendly code.
+  # This means all the calls to acorn_optimizer that come after this will now run without
+  # --closure-friendly
+  settings.MAYBE_CLOSURE_COMPILER = False
+
   cmd = closure_cmd + args
   return run_closure_cmd(cmd, filename, env)
 

tools/link.py

@@ -2561,6 +2561,9 @@ def modularize():
   shared.get_temp_files().note(final_js)
   save_intermediate('modularized')
 
+  if settings.MINIFY_WHITESPACE:
+    final_js = building.acorn_optimizer(final_js, ['--minify-whitespace'])
+
 
 def module_export_name_substitution():
   assert not settings.MODULARIZE