Enable ruff C4 checks. NFC (#24209)

Author: sbc100

emrun.py

@@ -967,7 +967,7 @@ def get_browser_build_date(filename):
       info = plistlib.readPlist(plistfile)
       # Data in Info.plists is a bit odd, this check combo gives best information on each browser.
       if 'firefox' in filename.lower():
-        return '20' + '-'.join(map((lambda x: x.zfill(2)), info['CFBundleVersion'][2:].split('.')))
+        return '20' + '-'.join(x.zfill(2) for x in info['CFBundleVersion'][2:].split('.'))
   except Exception as e:
     logv(e)
 

pyproject.toml

@@ -19,6 +19,7 @@ lint.select = [
   "ARG",
   "ASYNC",
   "B",
+  "C4",
   "C90",
   "COM",
   "E",

site/source/get_api_items.py

@@ -22,7 +22,7 @@
 # if you change here, change everywhere.
 api_item_filename = 'api_items.py'
 
-api_reference_items = dict()
+api_reference_items = {}
 
 
 def parseFiles():
@@ -78,9 +78,7 @@ def exportItems():
         # write function lead in
         infile.write("# Auto-generated file (see get_api_items.py)\n\ndef get_mapped_items():\n    mapped_wiki_inline_code = dict()\n")
 
-        items = list((key, value) for key, value in api_reference_items.items())
-        items.sort()
-        for key, value in items:
+        for key, value in sorted(api_reference_items.items()):
             # Write out each API item to add
             infile.write("    mapped_wiki_inline_code['%s'] = '%s'\n" % (key, value))
 

test/common.py

@@ -1283,7 +1283,7 @@ def tearDown(self):
         ]
 
         left_over_files = set(temp_files_after_run) - set(self.temp_files_before_run)
-        left_over_files = [f for f in left_over_files if not any([f.startswith(prefix) for prefix in ignorable_file_prefixes])]
+        left_over_files = [f for f in left_over_files if not any(f.startswith(p) for p in ignorable_file_prefixes)]
         if len(left_over_files):
           print('ERROR: After running test, there are ' + str(len(left_over_files)) + ' new temporary files/directories left behind:', file=sys.stderr)
           for f in left_over_files:

test/parallel_testsuite.py

@@ -81,7 +81,7 @@ def reversed_tests(self):
 
     Future work: measure slowness of tests and sort accordingly.
     """
-    return reversed(sorted(self, key=str))
+    return sorted(self, key=str, reverse=True)
 
   def combine_results(self, result, buffered_results):
     print()