Skip to content

Commit 0dfaf5e

Browse files
committed
Move relevant docs to config
1 parent 4a6e273 commit 0dfaf5e

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

dockers/llm.rag.service/config.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ class WeaviateSettings(BaseSettings):
3535
default="my_custom_index",
3636
alias="WEAVIATE_INDEX_NAME",
3737
)
38+
# TODO: consider moving to hybrid search config
3839
weaviate_hybrid_search_alpha: float = Field(
3940
default=0.5,
4041
alias="WEAVIATE_HYBRID_ALPHA",
@@ -43,12 +44,22 @@ class WeaviateSettings(BaseSettings):
4344
default="sentence-transformers/all-MiniLM-L6-v2",
4445
alias="EMBEDDING_MODEL_NAME",
4546
)
47+
# TODO: consider moving to hybrid search config
48+
hybrid_search_relevant_docs: Optional[int] = Field(
49+
default=2,
50+
alias="RELEVANT_DOCS",
51+
)
4652

4753
@field_validator("weaviate_hybrid_search_alpha", mode="before")
4854
@classmethod
4955
def validate_weaviate_hybrid_search_alpha(cls, v):
5056
return validate_float(v)
5157

58+
@field_validator("hybrid_search_relevant_docs", mode="before")
59+
@classmethod
60+
def validate_hybrid_search_relevant_docs(cls, v):
61+
return validate_int(v)
62+
5263
class Config:
5364
env_file = ".env"
5465
extra = "ignore"

dockers/llm.rag.service/serverragllm_csv_to_weaviate_local.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343

4444

4545
def setup(
46-
relevant_docs: int,
4746
sql_search_db_and_model_path: str,
4847
max_context_length: int,
4948
sql_ticket_source: str,
@@ -86,7 +85,7 @@ def setup(
8685
vectorstore=vectorstore,
8786
client=client,
8887
system_prompt=SYSTEM_PROMPT_DEFAULT,
89-
relevant_docs=relevant_docs,
88+
relevant_docs=weaviate_settings.hybrid_search_relevant_docs,
9089
sql_search_db_and_model_path=sql_search_db_and_model_path,
9190
alpha=weaviate_settings.weaviate_hybrid_search_alpha,
9291
max_context_length=max_context_length,
@@ -105,12 +104,9 @@ def read_item(question: Union[str, None] = None):
105104

106105
MICROSOFT_MODEL_ID = "microsoft/Phi-3-mini-4k-instruct"
107106
MOSAICML_MODEL_ID = "mosaicml/mpt-7b-chat"
108-
RELEVANT_DOCS_DEFAULT = 2
109107
SQL_SEARCH_DB_AND_MODEL_PATH_DEFAULT = "/app/db/"
110108
MODEL_MAX_CONTEXT_LEN = 8192
111109

112-
relevant_docs = int(os.getenv("RELEVANT_DOCS", RELEVANT_DOCS_DEFAULT))
113-
114110
sql_search_db_and_model_path = os.getenv(
115111
"SQL_SEARCH_DB_AND_MODEL_PATH", SQL_SEARCH_DB_AND_MODEL_PATH_DEFAULT
116112
)
@@ -122,7 +118,6 @@ def read_item(question: Union[str, None] = None):
122118
os.environ["TOKENIZERS_PARALLELISM"] = "false"
123119

124120
app = setup(
125-
relevant_docs,
126121
sql_search_db_and_model_path,
127122
max_context_length,
128123
sql_ticket_source,

0 commit comments

Comments
 (0)