The 'snap' command is deprecated, use 'pack' instead.

[esimkowitz]

app-builder-lib needs to be updated to use the snapcraft pack command instead of snap when packaging for Snap targets

[mmaietta]

electron-builder uses app-builder-bin under the hood to assemble snap packages. Please open an issue here to track https://github.com/develar/app-builder

[mmaietta]

@esimkowitz can you link me to the docs, or even cmd-line -help for the cmd, for snapcraft pack usage? I'm not finding any docs on it via the official docs https://snapcraft.io/docs/create-a-new-snap

Asking as it looks like the snap target implementation may need to be completely rewritten in JS. If so, would you be willing to help test the refactor once it is built out?

Related: Do you know when snap became the new cmd? Need to know so that I can do a semver check on which cmd to execute otherwise it's a breaking electron-builder semver bump.

[esimkowitz]

I believe snapcraft pack replaced snap like 6 years ago, at least according to the deprecation notice
https://snapcraft.io/docs/deprecation-notice-6

It says it was introduced in Snapcraft 2.35

Also yeah totally down to help test the new imlementation

[mmaietta]

Update: Working on a migration path atm from Go->TS: #8892 (Would love it if you could test the release afterwards. Tests pass on my Ubuntu arm64 VM and my mac for non-multipass tests. snapcraft and multipass are not available in docker containers or installable on mac GH runners it seems.)

Also turns out that snap unit tests were only snapshotting the cmd-line args being utilized for packaging the snap, so the CI new tests now actually test the full flow. 🎉

After a 1:1 migration, I'll explore the change to pack once the migration proves successful.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.