remove autodelete (#8)

Author: zuker

package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "@elastic.io/amqp-rpc",
   "description": "RPC over RabbitMQ for Node.js",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "homepage": "http://elastic.io",
   "author": "elastic.io GmbH <[email protected]>",
   "main": "src/index.js",

package.json

@@ -35,12 +35,13 @@ class AMQPEventsReceiver extends EventEmitter {
   async receive() {
     assert(!this._channel && !this._queue, 'Already receiving');
     this._channel = await this._connection.createChannel();
-    this._queue = await this._channel.assertQueue(this._queueName, {
-      autoDelete: true,
-      durabale: true
+    const queue = await this._channel.assertQueue(this._queueName, {
+      durable: true
     });
-    this._channel.consume(this._queue.queue, this._handleMessage.bind(this));
-    return this._queue.queue;
+    this._queueName = queue.queue;
+    this._channel.consume(this._queueName, this._handleMessage.bind(this));
+
+    return this._queueName;
   }
 
   /**
@@ -53,7 +54,7 @@ class AMQPEventsReceiver extends EventEmitter {
     const channel = this._channel;
     this._channel = null;
     try {
-      await channel.deleteQueue(this._queue.name);
+      await channel.deleteQueue(this._queueName);
     } catch (e) {
       //it's ok to ignore this error, as queue
       //may be deleted by AMQPStreamSender

src/AMQPEventsReceiver.js

@@ -25,20 +25,20 @@ describe('AMQPEventsReceiver', () => {
 
 
   describe('#contructor', () => {
-    it('should set default queueName', () => {
+
+    it('should be event emitter', () => {
       const receiver = new AMQPEventsReceiver(connectionStub);
-      expect(receiver).to.be.instanceof(AMQPEventsReceiver);
       expect(receiver).to.be.instanceof(EventEmitter);
+    });
+
+    it('should set connection', () => {
+      const receiver = new AMQPEventsReceiver(connectionStub);
       expect(receiver._connection).to.equal(connectionStub);
-      expect(receiver._queueName).to.equal('');
     });
 
     it('should set default queueName', () => {
       const queueName = 'q';
       const receiver = new AMQPEventsReceiver(connectionStub, queueName);
-      expect(receiver).to.be.instanceof(AMQPEventsReceiver);
-      expect(receiver).to.be.instanceof(EventEmitter);
-      expect(receiver._connection).to.equal(connectionStub, queueName);
       expect(receiver._queueName).to.equal(queueName);
     });
   });
@@ -66,19 +66,18 @@ describe('AMQPEventsReceiver', () => {
       expect(receiver._channel).to.equal(channelStub);
     });
 
-    it('should create amqp queue with autoDelete and durable flags', async () => {
+    it('should create amqp queue with options', async () => {
       const receiver = new AMQPEventsReceiver(connectionStub, 'q');
       const queueStub = {
-        queue: 'q'
+        queue: 'q1'
       };
       channelStub.assertQueue = sinon.stub().returns(Promise.resolve(queueStub));
       const queueName = await receiver.receive();
       expect(channelStub.assertQueue).to.have.been.calledOnce
-        .and.calledWith(receiver._queueName, {
-          autoDelete: true,
-          durabale: true
+        .and.calledWith('q', {
+          durable: true
         });
-      expect(receiver._queue).to.equal(queueStub);
+      expect(receiver._queueName).to.equal(queueStub.queue);
       expect(queueName).to.equal(queueStub.queue);
     });