-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Bug] Ensure only supported connectors appear in the Security Solution & Agent Builder AI connector selector #244533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…n & Agent Builder AI connector selector (elastic#244533) ## Summary Summarize your PR. If it involves visual changes, include a screenshot or gif. Fix bug where unsupported connectors appeared in the security ai assistant and agent builder connector selector. How to test the fix: - Set up an AI connector (inference) - In Additional settings, make sure "text embeddings" is selected <img width="828" height="416" alt="image" src="https://github.com/user-attachments/assets/328d7f9c-4c4c-412c-95dd-7bcb8f37077e" /> (to set up a text embedding connector, I used a personal OpenAI key and picked one of the OpenAI embedding models) - Go to the security AI assistant and open the connector drop-down. - Ensure your text embeddings connector does not appear. - Check text embedding connector does not appear in the agent builder connector selector either Previously, the embedding connector would appear but be unusable. Example: Incompatible AI connector <img width="1734" height="1784" alt="image" src="https://github.com/user-attachments/assets/51fe0a2c-c6fe-455d-8caa-b7c437f7cc31" /> Compatible AI connector <img width="1796" height="1816" alt="image" src="https://github.com/user-attachments/assets/5ed5d7cd-b620-40ce-b46e-df5a0bf3d796" /> Security connector Selector should look like this: <img width="910" height="928" alt="image" src="https://github.com/user-attachments/assets/44dc00fb-c55f-4bf1-9e77-9f0cf2b8799e" /> Agent builder connector selector should look like this: <img width="728" height="379" alt="image" src="https://github.com/user-attachments/assets/00b15daa-1c73-44b8-b1fa-b7db3916d326" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit d128d41) # Conflicts: # x-pack/platform/packages/shared/kbn-elastic-assistant/impl/mock/connectors.ts
…n & Agent Builder AI connector selector (elastic#244533) ## Summary Summarize your PR. If it involves visual changes, include a screenshot or gif. Fix bug where unsupported connectors appeared in the security ai assistant and agent builder connector selector. How to test the fix: - Set up an AI connector (inference) - In Additional settings, make sure "text embeddings" is selected <img width="828" height="416" alt="image" src="https://github.com/user-attachments/assets/328d7f9c-4c4c-412c-95dd-7bcb8f37077e" /> (to set up a text embedding connector, I used a personal OpenAI key and picked one of the OpenAI embedding models) - Go to the security AI assistant and open the connector drop-down. - Ensure your text embeddings connector does not appear. - Check text embedding connector does not appear in the agent builder connector selector either Previously, the embedding connector would appear but be unusable. Example: Incompatible AI connector <img width="1734" height="1784" alt="image" src="https://github.com/user-attachments/assets/51fe0a2c-c6fe-455d-8caa-b7c437f7cc31" /> Compatible AI connector <img width="1796" height="1816" alt="image" src="https://github.com/user-attachments/assets/5ed5d7cd-b620-40ce-b46e-df5a0bf3d796" /> Security connector Selector should look like this: <img width="910" height="928" alt="image" src="https://github.com/user-attachments/assets/44dc00fb-c55f-4bf1-9e77-9f0cf2b8799e" /> Agent builder connector selector should look like this: <img width="728" height="379" alt="image" src="https://github.com/user-attachments/assets/00b15daa-1c73-44b8-b1fa-b7db3916d326" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit d128d41) # Conflicts: # x-pack/platform/packages/shared/kbn-elastic-assistant/impl/mock/connectors.ts
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…n & Agent Builder AI connector selector (elastic#244533) ## Summary Summarize your PR. If it involves visual changes, include a screenshot or gif. Fix bug where unsupported connectors appeared in the security ai assistant and agent builder connector selector. How to test the fix: - Set up an AI connector (inference) - In Additional settings, make sure "text embeddings" is selected <img width="828" height="416" alt="image" src="https://github.com/user-attachments/assets/328d7f9c-4c4c-412c-95dd-7bcb8f37077e" /> (to set up a text embedding connector, I used a personal OpenAI key and picked one of the OpenAI embedding models) - Go to the security AI assistant and open the connector drop-down. - Ensure your text embeddings connector does not appear. - Check text embedding connector does not appear in the agent builder connector selector either Previously, the embedding connector would appear but be unusable. Example: Incompatible AI connector <img width="1734" height="1784" alt="image" src="https://github.com/user-attachments/assets/51fe0a2c-c6fe-455d-8caa-b7c437f7cc31" /> Compatible AI connector <img width="1796" height="1816" alt="image" src="https://github.com/user-attachments/assets/5ed5d7cd-b620-40ce-b46e-df5a0bf3d796" /> Security connector Selector should look like this: <img width="910" height="928" alt="image" src="https://github.com/user-attachments/assets/44dc00fb-c55f-4bf1-9e77-9f0cf2b8799e" /> Agent builder connector selector should look like this: <img width="728" height="379" alt="image" src="https://github.com/user-attachments/assets/00b15daa-1c73-44b8-b1fa-b7db3916d326" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit d128d41) # Conflicts: # x-pack/platform/packages/shared/kbn-elastic-assistant/impl/mock/connectors.ts
…n & Agent Builder AI connector selector (elastic#244533) ## Summary Summarize your PR. If it involves visual changes, include a screenshot or gif. Fix bug where unsupported connectors appeared in the security ai assistant and agent builder connector selector. How to test the fix: - Set up an AI connector (inference) - In Additional settings, make sure "text embeddings" is selected <img width="828" height="416" alt="image" src="https://github.com/user-attachments/assets/328d7f9c-4c4c-412c-95dd-7bcb8f37077e" /> (to set up a text embedding connector, I used a personal OpenAI key and picked one of the OpenAI embedding models) - Go to the security AI assistant and open the connector drop-down. - Ensure your text embeddings connector does not appear. - Check text embedding connector does not appear in the agent builder connector selector either Previously, the embedding connector would appear but be unusable. Example: Incompatible AI connector <img width="1734" height="1784" alt="image" src="https://github.com/user-attachments/assets/51fe0a2c-c6fe-455d-8caa-b7c437f7cc31" /> Compatible AI connector <img width="1796" height="1816" alt="image" src="https://github.com/user-attachments/assets/5ed5d7cd-b620-40ce-b46e-df5a0bf3d796" /> Security connector Selector should look like this: <img width="910" height="928" alt="image" src="https://github.com/user-attachments/assets/44dc00fb-c55f-4bf1-9e77-9f0cf2b8799e" /> Agent builder connector selector should look like this: <img width="728" height="379" alt="image" src="https://github.com/user-attachments/assets/00b15daa-1c73-44b8-b1fa-b7db3916d326" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit d128d41) # Conflicts: # x-pack/platform/packages/shared/kbn-elastic-assistant/impl/mock/connectors.ts
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
3 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
…n & Agent Builder AI connector selector (elastic#244533) ## Summary Summarize your PR. If it involves visual changes, include a screenshot or gif. Fix bug where unsupported connectors appeared in the security ai assistant and agent builder connector selector. How to test the fix: - Set up an AI connector (inference) - In Additional settings, make sure "text embeddings" is selected <img width="828" height="416" alt="image" src="https://github.com/user-attachments/assets/328d7f9c-4c4c-412c-95dd-7bcb8f37077e" /> (to set up a text embedding connector, I used a personal OpenAI key and picked one of the OpenAI embedding models) - Go to the security AI assistant and open the connector drop-down. - Ensure your text embeddings connector does not appear. - Check text embedding connector does not appear in the agent builder connector selector either Previously, the embedding connector would appear but be unusable. Example: Incompatible AI connector <img width="1734" height="1784" alt="image" src="https://github.com/user-attachments/assets/51fe0a2c-c6fe-455d-8caa-b7c437f7cc31" /> Compatible AI connector <img width="1796" height="1816" alt="image" src="https://github.com/user-attachments/assets/5ed5d7cd-b620-40ce-b46e-df5a0bf3d796" /> Security connector Selector should look like this: <img width="910" height="928" alt="image" src="https://github.com/user-attachments/assets/44dc00fb-c55f-4bf1-9e77-9f0cf2b8799e" /> Agent builder connector selector should look like this: <img width="728" height="379" alt="image" src="https://github.com/user-attachments/assets/00b15daa-1c73-44b8-b1fa-b7db3916d326" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <[email protected]>
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
16 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
3 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Summary
Summarize your PR. If it involves visual changes, include a screenshot or gif.
Fix bug where unsupported connectors appeared in the security ai assistant and agent builder connector selector.
How to test the fix:
(to set up a text embedding connector, I used a personal OpenAI key and picked one of the OpenAI embedding models)
Previously, the embedding connector would appear but be unusable.
Example:
Incompatible AI connector

Compatible AI connector

Security connector Selector should look like this:

Agent builder connector selector should look like this:

Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.