Skip to content

[canvas] embeddables not refreshing on manual refresh or auto-refresh #221321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nreese opened this issue May 22, 2025 · 0 comments · Fixed by #221326
Closed

[canvas] embeddables not refreshing on manual refresh or auto-refresh #221321

nreese opened this issue May 22, 2025 · 0 comments · Fixed by #221326
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented May 22, 2025 •
edited
Loading

There are 2 separate problems

  1. manual refresh not working (8.19/9.1). Regression caused by [Embeddables] Serialized State Only #215947. [Embeddables] Serialized State Only #215947 moved x-pack/platform/plugins/private/canvas/public/components/hooks/use_canvas_api.tsx reload$ from file scope to callback scope.
  2. auto refresh not working (8.16.4/8.17.3/8.18.0/8.19/9.0/9.1). Regression caused by [canvas] fix All embeddables rebuilt on refresh #209677. Auto refresh is not triggering reload$. Canvas triggers reload in several locations and not all were updated in 209677.
@nreese nreese added the bug Fixes for quality problems that affect the customer experience label May 22, 2025
@botelastic botelastic bot added the needs-team Issues missing a team label label May 22, 2025
@nreese nreese added regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed needs-team Issues missing a team label labels May 22, 2025
@nreese nreese self-assigned this May 22, 2025
@nreese nreese mentioned this issue May 22, 2025
Merged
nreese added a commit that referenced this issue May 23, 2025
@nreese @elasticmachine
[canvas] fix embeddables not refreshing on manual refresh or auto-ref…
e937e91 
…resh (#221326)

Fixes #221321

### test instructions
1) install sample web logs
2) import canvas saved object
https://github.com/nreese/notes/blob/master/empty-canvas-workpad-saved-object-export.ndjson
3) refresh kibana
4) open canvas and add map embeddable
5) open browser network tab
6) click "Refresh data" button. Verify map requests new data
7) open "View" menu. Click "Refresh data". Verify map requests new data
8) set auto internal to "5s". Verify map requests new data on each
interval

---------

Co-authored-by: Elastic Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 23, 2025
@nreese @elasticmachine
[canvas] fix embeddables not refreshing on manual refresh or auto-ref…
0ba4b3f 
…resh (elastic#221326)

Fixes elastic#221321

### test instructions
1) install sample web logs
2) import canvas saved object
https://github.com/nreese/notes/blob/master/empty-canvas-workpad-saved-object-export.ndjson
3) refresh kibana
4) open canvas and add map embeddable
5) open browser network tab
6) click "Refresh data" button. Verify map requests new data
7) open "View" menu. Click "Refresh data". Verify map requests new data
8) set auto internal to "5s". Verify map requests new data on each
interval

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit e937e91)
nreese added a commit to nreese/kibana that referenced this issue May 23, 2025
@nreese
[canvas] fix embeddables not refreshing on manual refresh or auto-ref…
24e4c72 
…resh (elastic#221326)

Fixes elastic#221321

### test instructions
1) install sample web logs
2) import canvas saved object
https://github.com/nreese/notes/blob/master/empty-canvas-workpad-saved-object-export.ndjson
3) refresh kibana
4) open canvas and add map embeddable
5) open browser network tab
6) click "Refresh data" button. Verify map requests new data
7) open "View" menu. Click "Refresh data". Verify map requests new data
8) set auto internal to "5s". Verify map requests new data on each
interval

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit e937e91)

# Conflicts:
#	x-pack/platform/plugins/private/canvas/public/components/hooks/use_canvas_api.tsx
#	x-pack/platform/plugins/private/canvas/types/embeddables.ts
nreese added a commit to nreese/kibana that referenced this issue May 23, 2025
@nreese
[canvas] fix embeddables not refreshing on manual refresh or auto-ref…
f757fd7 
…resh (elastic#221326)

Fixes elastic#221321

### test instructions
1) install sample web logs
2) import canvas saved object
https://github.com/nreese/notes/blob/master/empty-canvas-workpad-saved-object-export.ndjson
3) refresh kibana
4) open canvas and add map embeddable
5) open browser network tab
6) click "Refresh data" button. Verify map requests new data
7) open "View" menu. Click "Refresh data". Verify map requests new data
8) set auto internal to "5s". Verify map requests new data on each
interval

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit e937e91)

# Conflicts:
#	x-pack/platform/plugins/private/canvas/public/components/hooks/use_canvas_api.tsx
#	x-pack/platform/plugins/private/canvas/types/embeddables.ts
nreese added a commit to nreese/kibana that referenced this issue May 23, 2025
@nreese
[canvas] fix embeddables not refreshing on manual refresh or auto-ref…
15c1c7d 
…resh (elastic#221326)

Fixes elastic#221321

### test instructions
1) install sample web logs
2) import canvas saved object
https://github.com/nreese/notes/blob/master/empty-canvas-workpad-saved-object-export.ndjson
3) refresh kibana
4) open canvas and add map embeddable
5) open browser network tab
6) click "Refresh data" button. Verify map requests new data
7) open "View" menu. Click "Refresh data". Verify map requests new data
8) set auto internal to "5s". Verify map requests new data on each
interval

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit e937e91)

# Conflicts:
#	x-pack/platform/plugins/private/canvas/public/components/hooks/use_canvas_api.tsx
#	x-pack/plugins/canvas/types/embeddables.ts
nreese added a commit to nreese/kibana that referenced this issue May 23, 2025
@nreese
[canvas] fix embeddables not refreshing on manual refresh or auto-ref…
4d565be 
…resh (elastic#221326)

Fixes elastic#221321

### test instructions
1) install sample web logs
2) import canvas saved object
https://github.com/nreese/notes/blob/master/empty-canvas-workpad-saved-object-export.ndjson
3) refresh kibana
4) open canvas and add map embeddable
5) open browser network tab
6) click "Refresh data" button. Verify map requests new data
7) open "View" menu. Click "Refresh data". Verify map requests new data
8) set auto internal to "5s". Verify map requests new data on each
interval

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit e937e91)

# Conflicts:
#	x-pack/platform/plugins/private/canvas/public/components/hooks/use_canvas_api.tsx
#	x-pack/plugins/canvas/types/embeddables.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[canvas] fix embeddables not refreshing on manual refresh or auto-refresh nreese/kibana
1 participant
@nreese