Skip to content

Commit d4dbb25

Browse files
committed
[ES|QL] suggest pipe after single column in EVAL (#221851)
## Summary Previously, we weren't considering an assignment with a single field name to be a "complete" expression in `EVAL`. This changes that because it seems like people are using `EVAL` for this, even though we also have a `RENAME` command. https://github.com/user-attachments/assets/eab58527-ebfa-45bc-abb1-63b996ebbeac (cherry picked from commit 8659427)
1 parent 6bb4436 commit d4dbb25

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/autocomplete/__tests__/autocomplete.command.eval.test.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,12 @@ describe('autocomplete.suggest', () => {
148148
]);
149149
});
150150

151+
test('after column after assignment', async () => {
152+
const { suggest } = await setup();
153+
const suggestions = await suggest('from a | eval col = doubleField /');
154+
expect(suggestions.map((s) => s.text)).toContain('| ');
155+
});
156+
151157
test('after NOT', async () => {
152158
await assertSuggestions('from index | EVAL keywordField not /', [
153159
'LIKE $0',

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/autocomplete/commands/eval/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export async function suggest(
5151
// don't suggest finishing characters if the expression is a column
5252
// because "EVAL columnName" is a useless expression
5353
expressionRoot &&
54-
!isColumnItem(expressionRoot)
54+
(!isColumnItem(expressionRoot) || insideAssignment)
5555
) {
5656
suggestions.push(pipeCompleteItem, { ...commaCompleteItem, text: ', ' });
5757
}

0 commit comments

Comments
 (0)