Skip to content

Commit 4332884

Browse files
authored
[Snapshot and restore] Set file system repo compression to true by default (#221500)
Closes #210481 So far, file system was the only type of repository that had compression set to false by default. But according with the [ES docs ](https://www.elastic.co/docs/deploy-manage/tools/snapshot-and-restore/shared-file-system-repository) that default is true: ``` compress (Optional, Boolean) If true, metadata files, such as index mappings and settings, are compressed in snapshots. Data files are not compressed. Defaults to true. ``` So this PR sets the default to true for FS. https://github.com/user-attachments/assets/b14e24a9-0330-4cbf-863b-102030d70f92
1 parent 12784c2 commit 4332884

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

x-pack/platform/plugins/private/snapshot_restore/__jest__/client_integration/repository_add.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ describe('<RepositoryAdd />', () => {
236236
type: fsRepository.type,
237237
settings: {
238238
location: fsRepository.settings.location,
239-
compress: true,
239+
compress: false,
240240
chunkSize: fsRepository.settings.chunkSize,
241241
maxSnapshotBytesPerSec: fsRepository.settings.maxSnapshotBytesPerSec,
242242
maxRestoreBytesPerSec: fsRepository.settings.maxRestoreBytesPerSec,

x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/fs_settings.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export const FSSettings: React.FunctionComponent<Props> = ({
133133
defaultMessage="Compress snapshots"
134134
/>
135135
}
136-
checked={!!compress}
136+
checked={!(compress === false)}
137137
onChange={(e) => {
138138
updateRepositorySettings({
139139
compress: e.target.checked,

x-pack/test/functional/page_objects/snapshot_restore_page.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,6 @@ export function SnapshotRestorePageProvider({ getService }: FtrProviderContext)
249249
},
250250
async createSourceOnlyRepositoryStepTwo(location: string) {
251251
await testSubjects.setValue('locationInput', location);
252-
await testSubjects.click('compressToggle');
253252
await testSubjects.click('submitButton');
254253
await retry.waitFor('repository list to be visible', async () => {
255254
return await testSubjects.isDisplayed('repositoryList');

0 commit comments

Comments
 (0)