Skip to content

Introduce series-based event discovery to limit processing to relevant events #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ferishili
Copy link
Contributor

@ferishili ferishili commented May 26, 2025

This PR (partialy) fixes #1372,

This PR introduces a new discovery method to ensure only events related to the current Stud.IP instance are processed.

  • Events without a series ID will still be processed, as there's no reliable way to determine their relevance.

  • Events with a series ID will be checked against the list of known series for the current instance. If the series is unknown, the event is skipped as unrelated.

[UPDATE]: with latest changes new approaches have been added:

  • Upload from Workspace gets the series id from user.
  • A checker-mapper mechanism has been introduced to make sure that events without series but related to any users in the studip (owner) gets series from user

…t events,

This PR introduces a new discovery method to ensure only events related to the current Stud.IP instance are processed.

- Events without a series ID will still be processed, as there's no reliable way to determine their relevance.

- Events with a series ID will be checked against the list of known series for the current instance. If the series is unknown, the event is skipped as unrelated.
@ferishili ferishili self-assigned this May 26, 2025
@ferishili ferishili added type:enhancement type:bug v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x labels May 26, 2025
@ferishili ferishili marked this pull request as ready for review May 26, 2025 15:09
@ferishili ferishili requested a review from tgloeggl May 26, 2025 15:09
@ferishili
Copy link
Contributor Author

ferishili commented Jun 4, 2025

Discussion:

  • We have to pass the user series_id when uploading from the workplace!
  • We have to write the migration to add missing user series_id to the oc by only changing the metadata is_part_of and republish:
    • Using Perms "owner" to find out the video -> user -> user series!
    • Multi owners: pick one random!

[UPDATE]: I found that taking the migration approach would impose significant constraints on Opencast for a certain period, which could potentially lead to unintended behavior.
To address this, I came up with an alternative: delegating the task to the discovery worker instead. This way, the processing can happen more gradually and reliably over time.
What’s your opinion on this, @tgloeggl?

Copy link

github-actions bot commented Jun 4, 2025

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

- pass user series when uploading from workspace
- add a checker/mapper to insert user series for those events without series based on perms "owner"
@ferishili
Copy link
Contributor Author

@tgloeggl;
changes are applied please proceed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug type:enhancement v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wechselwirkung der Cronjobs bei mehreren Stud.IP-Instanzen
1 participant