Fix playlist sync db issue #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsuring non-nullable columns
ferishili
added
type:bug
v:3
|
It seems that the playlists migration step fails in the tests:
With the change in #1368, the curl command should fail on errors. |
|
The tests are green now! Please help me make this name change known/notified! [UPDATE]: with separate query we use the same fkey! So ignore this comment! |
dennis531
reviewed
May 22, 2025
|
Separate query worked thanks @dennis531 |
dennis531
approved these changes
Jun 2, 2025
|
Discussion:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1255, which enhances playlist migration by enforcing foreign key constraints and make sure the non-nullable columns changes are correctly applied!
PS: the testing environement was a bit confusing for me to make sure that it is working properly, so please test this through!