Skip to content

Commit d91c3da

Browse files
ehsavoieehsavoie
committed
fix!: Rename ListTaskPushNotificationConfig to plural ListTaskPushNotificationConfigs for consistency
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
1 parent 5af2b29 commit d91c3da

File tree

42 files changed

+313
-313
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+313
-313
lines changed

‎client/base/src/main/java/io/a2a/client/AbstractClient.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
import io.a2a.spec.CancelTaskParams;
1515
import io.a2a.spec.DeleteTaskPushNotificationConfigParams;
1616
import io.a2a.spec.GetTaskPushNotificationConfigParams;
17-
import io.a2a.spec.ListTaskPushNotificationConfigParams;
18-
import io.a2a.spec.ListTaskPushNotificationConfigResult;
17+
import io.a2a.spec.ListTaskPushNotificationConfigsParams;
18+
import io.a2a.spec.ListTaskPushNotificationConfigsResult;
1919
import io.a2a.spec.ListTasksParams;
2020
import io.a2a.spec.Message;
2121
import io.a2a.spec.MessageSendParams;
@@ -299,8 +299,8 @@ public abstract TaskPushNotificationConfig getTaskPushNotificationConfiguration(
299299
* @return the result containing the list of task push notification configs and pagination information
300300
* @throws A2AClientException if getting the task push notification configs fails for any reason
301301
*/
302-
public ListTaskPushNotificationConfigResult listTaskPushNotificationConfigurations(
303-
ListTaskPushNotificationConfigParams request) throws A2AClientException {
302+
public ListTaskPushNotificationConfigsResult listTaskPushNotificationConfigurations(
303+
ListTaskPushNotificationConfigsParams request) throws A2AClientException {
304304
return listTaskPushNotificationConfigurations(request, null);
305305
}
306306

@@ -312,8 +312,8 @@ public ListTaskPushNotificationConfigResult listTaskPushNotificationConfiguratio
312312
* @return the result containing the list of task push notification configs and pagination information
313313
* @throws A2AClientException if getting the task push notification configs fails for any reason
314314
*/
315-
public abstract ListTaskPushNotificationConfigResult listTaskPushNotificationConfigurations(
316-
ListTaskPushNotificationConfigParams request,
315+
public abstract ListTaskPushNotificationConfigsResult listTaskPushNotificationConfigurations(
316+
ListTaskPushNotificationConfigsParams request,
317317
@Nullable ClientCallContext context) throws A2AClientException;
318318

319319
/**

‎client/base/src/main/java/io/a2a/client/Client.java‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
import io.a2a.spec.EventKind;
2121
import io.a2a.spec.GetExtendedAgentCardParams;
2222
import io.a2a.spec.GetTaskPushNotificationConfigParams;
23-
import io.a2a.spec.ListTaskPushNotificationConfigParams;
24-
import io.a2a.spec.ListTaskPushNotificationConfigResult;
23+
import io.a2a.spec.ListTaskPushNotificationConfigsParams;
24+
import io.a2a.spec.ListTaskPushNotificationConfigsResult;
2525
import io.a2a.spec.ListTasksParams;
2626
import io.a2a.spec.Message;
2727
import io.a2a.spec.MessageSendConfiguration;
@@ -512,9 +512,9 @@ public TaskPushNotificationConfig getTaskPushNotificationConfiguration(
512512
* Example:
513513
* <pre>{@code
514514
* // List all configurations for a context
515-
* ListTaskPushNotificationConfigParams params =
516-
* new ListTaskPushNotificationConfigParams("session-123", null, 10, null);
517-
* ListTaskPushNotificationConfigResult result =
515+
* ListTaskPushNotificationConfigsParams params =
516+
* new ListTaskPushNotificationConfigsParams("session-123", null, 10, null);
517+
* ListTaskPushNotificationConfigsResult result =
518518
* client.listTaskPushNotificationConfigurations(params);
519519
* for (TaskPushNotificationConfig config : result.configurations()) {
520520
* System.out.println("Task " + config.taskId() + " -> " +
@@ -526,11 +526,11 @@ public TaskPushNotificationConfig getTaskPushNotificationConfiguration(
526526
* @param context custom call context for request interceptors (optional)
527527
* @return the list of push notification configurations
528528
* @throws A2AClientException if the configurations cannot be retrieved
529-
* @see ListTaskPushNotificationConfigParams
529+
* @see ListTaskPushNotificationConfigsParams
530530
*/
531531
@Override
532-
public ListTaskPushNotificationConfigResult listTaskPushNotificationConfigurations(
533-
ListTaskPushNotificationConfigParams request, @Nullable ClientCallContext context) throws A2AClientException {
532+
public ListTaskPushNotificationConfigsResult listTaskPushNotificationConfigurations(
533+
ListTaskPushNotificationConfigsParams request, @Nullable ClientCallContext context) throws A2AClientException {
534534
return clientTransport.listTaskPushNotificationConfigurations(request, context);
535535
}
536536

‎client/transport/grpc/src/main/java/io/a2a/client/transport/grpc/GrpcTransport.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@
3838
import io.a2a.spec.EventKind;
3939
import io.a2a.spec.GetExtendedAgentCardParams;
4040
import io.a2a.spec.GetTaskPushNotificationConfigParams;
41-
import io.a2a.spec.ListTaskPushNotificationConfigParams;
42-
import io.a2a.spec.ListTaskPushNotificationConfigResult;
41+
import io.a2a.spec.ListTaskPushNotificationConfigsParams;
42+
import io.a2a.spec.ListTaskPushNotificationConfigsResult;
4343
import io.a2a.spec.ListTasksParams;
4444
import io.a2a.spec.MessageSendParams;
4545
import io.a2a.spec.StreamingEventKind;
@@ -271,8 +271,8 @@ public TaskPushNotificationConfig getTaskPushNotificationConfiguration(GetTaskPu
271271
}
272272

273273
@Override
274-
public ListTaskPushNotificationConfigResult listTaskPushNotificationConfigurations(
275-
ListTaskPushNotificationConfigParams request,
274+
public ListTaskPushNotificationConfigsResult listTaskPushNotificationConfigurations(
275+
ListTaskPushNotificationConfigsParams request,
276276
@Nullable ClientCallContext context) throws A2AClientException {
277277
checkNotNullParam("request", request);
278278

@@ -288,7 +288,7 @@ public ListTaskPushNotificationConfigResult listTaskPushNotificationConfiguratio
288288
try {
289289
A2AServiceBlockingV2Stub stubWithMetadata = createBlockingStubWithMetadata(context, payloadAndHeaders);
290290
io.a2a.grpc.ListTaskPushNotificationConfigsResponse grpcResponse = stubWithMetadata.listTaskPushNotificationConfigs(grpcRequest);
291-
return FromProto.listTaskPushNotificationConfigResult(grpcResponse);
291+
return FromProto.listTaskPushNotificationConfigsResult(grpcResponse);
292292
} catch (StatusRuntimeException | StatusException e) {
293293
throw GrpcErrorMapper.mapGrpcError(e, "Failed to list task push notification config: ");
294294
}

‎client/transport/jsonrpc/src/main/java/io/a2a/client/transport/jsonrpc/JSONRPCTransport.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@
5454
import io.a2a.spec.EventKind;
5555
import io.a2a.spec.GetExtendedAgentCardParams;
5656
import io.a2a.spec.GetTaskPushNotificationConfigParams;
57-
import io.a2a.spec.ListTaskPushNotificationConfigParams;
58-
import io.a2a.spec.ListTaskPushNotificationConfigResult;
57+
import io.a2a.spec.ListTaskPushNotificationConfigsParams;
58+
import io.a2a.spec.ListTaskPushNotificationConfigsResult;
5959
import io.a2a.spec.ListTasksParams;
6060
import io.a2a.spec.MessageSendParams;
6161
import io.a2a.spec.StreamingEventKind;
@@ -220,12 +220,12 @@ public TaskPushNotificationConfig getTaskPushNotificationConfiguration(GetTaskPu
220220
}
221221

222222
@Override
223-
public ListTaskPushNotificationConfigResult listTaskPushNotificationConfigurations(
224-
ListTaskPushNotificationConfigParams request,
223+
public ListTaskPushNotificationConfigsResult listTaskPushNotificationConfigurations(
224+
ListTaskPushNotificationConfigsParams request,
225225
@Nullable ClientCallContext context) throws A2AClientException {
226226
checkNotNullParam("request", request);
227227
PayloadAndHeaders payloadAndHeaders = applyInterceptors(LIST_TASK_PUSH_NOTIFICATION_CONFIG_METHOD,
228-
ProtoUtils.ToProto.listTaskPushNotificationConfigRequest(request), agentCard, context);
228+
ProtoUtils.ToProto.listTaskPushNotificationConfigsRequest(request), agentCard, context);
229229

230230
try {
231231
String httpResponseBody = sendPostRequest(Utils.buildBaseUrl(agentInterface, request.tenant()), payloadAndHeaders, LIST_TASK_PUSH_NOTIFICATION_CONFIG_METHOD);

‎client/transport/rest/src/main/java/io/a2a/client/transport/rest/RestTransport.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@
4848
import io.a2a.spec.EventKind;
4949
import io.a2a.spec.GetExtendedAgentCardParams;
5050
import io.a2a.spec.GetTaskPushNotificationConfigParams;
51-
import io.a2a.spec.ListTaskPushNotificationConfigParams;
52-
import io.a2a.spec.ListTaskPushNotificationConfigResult;
51+
import io.a2a.spec.ListTaskPushNotificationConfigsParams;
52+
import io.a2a.spec.ListTaskPushNotificationConfigsResult;
5353
import io.a2a.spec.ListTasksParams;
5454
import io.a2a.spec.MessageSendParams;
5555
import io.a2a.spec.StreamingEventKind;
@@ -326,7 +326,7 @@ public TaskPushNotificationConfig getTaskPushNotificationConfiguration(GetTaskPu
326326
}
327327

328328
@Override
329-
public ListTaskPushNotificationConfigResult listTaskPushNotificationConfigurations(ListTaskPushNotificationConfigParams request, @Nullable ClientCallContext context) throws A2AClientException {
329+
public ListTaskPushNotificationConfigsResult listTaskPushNotificationConfigurations(ListTaskPushNotificationConfigsParams request, @Nullable ClientCallContext context) throws A2AClientException {
330330
checkNotNullParam("request", request);
331331
io.a2a.grpc.ListTaskPushNotificationConfigsRequest.Builder builder
332332
= io.a2a.grpc.ListTaskPushNotificationConfigsRequest.newBuilder();
@@ -348,7 +348,7 @@ public ListTaskPushNotificationConfigResult listTaskPushNotificationConfiguratio
348348
String httpResponseBody = response.body();
349349
io.a2a.grpc.ListTaskPushNotificationConfigsResponse.Builder responseBuilder = io.a2a.grpc.ListTaskPushNotificationConfigsResponse.newBuilder();
350350
JsonFormat.parser().merge(httpResponseBody, responseBuilder);
351-
return ProtoUtils.FromProto.listTaskPushNotificationConfigResult(responseBuilder);
351+
return ProtoUtils.FromProto.listTaskPushNotificationConfigsResult(responseBuilder);
352352
} catch (A2AClientException e) {
353353
throw e;
354354
} catch (IOException | InterruptedException e) {

‎client/transport/rest/src/test/java/io/a2a/client/transport/rest/RestTransportTest.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@
4646
import io.a2a.spec.FileWithBytes;
4747
import io.a2a.spec.FileWithUri;
4848
import io.a2a.spec.GetTaskPushNotificationConfigParams;
49-
import io.a2a.spec.ListTaskPushNotificationConfigParams;
50-
import io.a2a.spec.ListTaskPushNotificationConfigResult;
49+
import io.a2a.spec.ListTaskPushNotificationConfigsParams;
50+
import io.a2a.spec.ListTaskPushNotificationConfigsResult;
5151
import io.a2a.spec.Message;
5252
import io.a2a.spec.MessageSendConfiguration;
5353
import io.a2a.spec.MessageSendParams;
@@ -357,8 +357,8 @@ public void testListTaskPushNotificationConfigurations() throws Exception {
357357
);
358358

359359
RestTransport client = new RestTransport(CARD);
360-
ListTaskPushNotificationConfigResult result = client.listTaskPushNotificationConfigurations(
361-
new ListTaskPushNotificationConfigParams("de38c76d-d54c-436c-8b9f-4c2703648d64"), null);
360+
ListTaskPushNotificationConfigsResult result = client.listTaskPushNotificationConfigurations(
361+
new ListTaskPushNotificationConfigsParams("de38c76d-d54c-436c-8b9f-4c2703648d64"), null);
362362
assertEquals(2, result.configs().size());
363363
TaskPushNotificationConfig config0 = result.configs().get(0);
364364
assertNotNull(config0);

‎client/transport/spi/src/main/java/io/a2a/client/transport/spi/ClientTransport.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
import io.a2a.spec.EventKind;
1212
import io.a2a.spec.GetExtendedAgentCardParams;
1313
import io.a2a.spec.GetTaskPushNotificationConfigParams;
14-
import io.a2a.spec.ListTaskPushNotificationConfigParams;
15-
import io.a2a.spec.ListTaskPushNotificationConfigResult;
14+
import io.a2a.spec.ListTaskPushNotificationConfigsParams;
15+
import io.a2a.spec.ListTaskPushNotificationConfigsResult;
1616
import io.a2a.spec.ListTasksParams;
1717
import io.a2a.spec.MessageSendParams;
1818
import io.a2a.spec.StreamingEventKind;
@@ -111,8 +111,8 @@ TaskPushNotificationConfig getTaskPushNotificationConfiguration(
111111
* @return the result containing the list of task push notification configs and pagination information
112112
* @throws A2AClientException if getting the task push notification configs fails for any reason
113113
*/
114-
ListTaskPushNotificationConfigResult listTaskPushNotificationConfigurations(
115-
ListTaskPushNotificationConfigParams request,
114+
ListTaskPushNotificationConfigsResult listTaskPushNotificationConfigurations(
115+
ListTaskPushNotificationConfigsParams request,
116116
@Nullable ClientCallContext context) throws A2AClientException;
117117

118118
/**

‎extras/opentelemetry/client-propagation/src/main/java/io/a2a/extras/opentelemetry/client/propagation/OpenTelemetryClientPropagatorTransport.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
import io.a2a.spec.EventKind;
1111
import io.a2a.spec.GetExtendedAgentCardParams;
1212
import io.a2a.spec.GetTaskPushNotificationConfigParams;
13-
import io.a2a.spec.ListTaskPushNotificationConfigParams;
14-
import io.a2a.spec.ListTaskPushNotificationConfigResult;
13+
import io.a2a.spec.ListTaskPushNotificationConfigsParams;
14+
import io.a2a.spec.ListTaskPushNotificationConfigsResult;
1515
import io.a2a.spec.ListTasksParams;
1616
import io.a2a.spec.MessageSendParams;
1717
import io.a2a.spec.StreamingEventKind;
@@ -96,7 +96,7 @@ public TaskPushNotificationConfig getTaskPushNotificationConfiguration(GetTaskPu
9696
}
9797

9898
@Override
99-
public ListTaskPushNotificationConfigResult listTaskPushNotificationConfigurations(ListTaskPushNotificationConfigParams request,
99+
public ListTaskPushNotificationConfigsResult listTaskPushNotificationConfigurations(ListTaskPushNotificationConfigsParams request,
100100
@Nullable ClientCallContext context) throws A2AClientException {
101101
return delegate.listTaskPushNotificationConfigurations(request, propagateContext(context));
102102
}

‎extras/opentelemetry/client/src/main/java/io/a2a/extras/opentelemetry/client/OpenTelemetryClientTransport.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
import io.a2a.spec.EventKind;
2525
import io.a2a.spec.GetExtendedAgentCardParams;
2626
import io.a2a.spec.GetTaskPushNotificationConfigParams;
27-
import io.a2a.spec.ListTaskPushNotificationConfigParams;
28-
import io.a2a.spec.ListTaskPushNotificationConfigResult;
27+
import io.a2a.spec.ListTaskPushNotificationConfigsParams;
28+
import io.a2a.spec.ListTaskPushNotificationConfigsResult;
2929
import io.a2a.spec.ListTasksParams;
3030
import io.a2a.spec.MessageSendParams;
3131
import io.a2a.spec.StreamingEventKind;
@@ -306,7 +306,7 @@ public TaskPushNotificationConfig getTaskPushNotificationConfiguration(GetTaskPu
306306
}
307307

308308
@Override
309-
public ListTaskPushNotificationConfigResult listTaskPushNotificationConfigurations(ListTaskPushNotificationConfigParams request,
309+
public ListTaskPushNotificationConfigsResult listTaskPushNotificationConfigurations(ListTaskPushNotificationConfigsParams request,
310310
@Nullable ClientCallContext context) throws A2AClientException {
311311
ClientCallContext clientContext = createContext(context);
312312
SpanBuilder spanBuilder = tracer.spanBuilder(A2AMethods.LIST_TASK_PUSH_NOTIFICATION_CONFIG_METHOD).setSpanKind(SpanKind.CLIENT);
@@ -319,7 +319,7 @@ public ListTaskPushNotificationConfigResult listTaskPushNotificationConfiguratio
319319
}
320320
Span span = spanBuilder.startSpan();
321321
try (Scope scope = span.makeCurrent()) {
322-
ListTaskPushNotificationConfigResult result = delegate.listTaskPushNotificationConfigurations(request, clientContext);
322+
ListTaskPushNotificationConfigsResult result = delegate.listTaskPushNotificationConfigurations(request, clientContext);
323323
if (result != null && extractResponse()) {
324324
String responseValue = result.configs().stream()
325325
.map(TaskPushNotificationConfig::toString)

‎extras/opentelemetry/client/src/test/java/io/a2a/extras/opentelemetry/client/OpenTelemetryClientTransportTest.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
import io.a2a.spec.EventKind;
1515
import io.a2a.spec.GetExtendedAgentCardParams;
1616
import io.a2a.spec.GetTaskPushNotificationConfigParams;
17-
import io.a2a.spec.ListTaskPushNotificationConfigParams;
18-
import io.a2a.spec.ListTaskPushNotificationConfigResult;
17+
import io.a2a.spec.ListTaskPushNotificationConfigsParams;
18+
import io.a2a.spec.ListTaskPushNotificationConfigsResult;
1919
import io.a2a.spec.ListTasksParams;
2020
import io.a2a.spec.Message;
2121
import io.a2a.spec.MessageSendParams;
@@ -262,16 +262,16 @@ void testGetTaskPushNotificationConfiguration_Success() throws A2AClientExceptio
262262

263263
@Test
264264
void testListTaskPushNotificationConfigurations_Success() throws A2AClientException {
265-
ListTaskPushNotificationConfigParams request = mock(ListTaskPushNotificationConfigParams.class);
265+
ListTaskPushNotificationConfigsParams request = mock(ListTaskPushNotificationConfigsParams.class);
266266
TaskPushNotificationConfig config1 = mock(TaskPushNotificationConfig.class);
267267
TaskPushNotificationConfig config2 = mock(TaskPushNotificationConfig.class);
268268
when(config1.toString()).thenReturn("config1");
269269
when(config2.toString()).thenReturn("config2");
270-
ListTaskPushNotificationConfigResult expectedResult = new ListTaskPushNotificationConfigResult(List.of(config1, config2));
270+
ListTaskPushNotificationConfigsResult expectedResult = new ListTaskPushNotificationConfigsResult(List.of(config1, config2));
271271
when(request.toString()).thenReturn("request-string");
272272
when(delegate.listTaskPushNotificationConfigurations(eq(request), any(ClientCallContext.class))).thenReturn(expectedResult);
273273

274-
ListTaskPushNotificationConfigResult result = transport.listTaskPushNotificationConfigurations(request, context);
274+
ListTaskPushNotificationConfigsResult result = transport.listTaskPushNotificationConfigurations(request, context);
275275

276276
assertEquals(expectedResult, result);
277277
verify(tracer).spanBuilder(A2AMethods.LIST_TASK_PUSH_NOTIFICATION_CONFIG_METHOD);

0 commit comments

Comments
 (0)