method stream-line-column doesn't specializ

[Yehouda]

hunchentoot/make-docstrings.lisp

Line 59 in 13876b5

(defmethod trivial-gray-streams:stream-line-column (stream)

This needs to specialize on formatting-stream.

On Lispworks that errors, because LispWorks exports stream-line-column and by default doesn't allow methods that are not specialized (so actually specilized on T) for such generic functions.

[stassats]

Can you make a pull request?

[Yehouda]

No, I don't work with github.
I test code that I downoad from quicklisp.
I checked that with the change the system compiles ok.

[stassats]

You can send me a patch from git format-patch.

[metayan]

@Yehouda Is this the change you have in mind?

diff --git a/make-docstrings.lisp b/make-docstrings.lisp
index 993a295..878781c 100644
--- a/make-docstrings.lisp
+++ b/make-docstrings.lisp
@@ -56,7 +56,7 @@ (defmethod trivial-gray-streams:stream-write-char ((stream formatting-stream) ch
          (vector-push-extend char (word-buffer stream))))
       (write-char char (understream stream))))
 
-(defmethod trivial-gray-streams:stream-line-column (stream)
+(defmethod trivial-gray-streams:stream-line-column ((stream formatting-stream))
   (+ (column stream) (length (word-buffer stream))))
 
 (defmethod trivial-gray-streams:stream-write-string ((stream formatting-stream) string &optional start end)

Maybe you can tell me how to invoke make-docstrings to test it.

[metayan]

Ah, I need to load hunchentoot-dev - not hunchentoot/dev.

[Yehouda]

Yes, this is the change.
huncentoot/dev is what comes from quicklisp, and as far as I can see it also in the source

hunchentoot/hunchentoot.asd

Line 88 in 13876b5

(defsystem :hunchentoot/dev

[Yehouda]

What is git format-patch?

[metayan]

The fix is in
https://github.com/metayan/hunchentoot/tree/fix238
@Yehouda Can you test that it works as intended?

How is 'make-docstrings:parse-docsupposed to be used, so I can test it with SBCL and CCL? I usehunchentoot`, but not this part.

[metayan]

By the way, my server, which is running hunchentoot on SBCL, was started 2023-08-24 10:00:38.

I have patched some things on-the-fly since then.
Lisp is great.