Skip to content

Commit 11f20f1

Browse files
Fix octothorpe comments in ESP32 partitions (#91)
The code took each partitions.csv line and cut off everything after a "#"....and then threq out the cut line and parsed the original. This means it would parse commented lines as if they just had a name of "#spiffs", for example. Actually use the trimmed line in calculations. Fixes #90
1 parent 4346cbf commit 11f20f1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ export function activate(context: vscode.ExtensionContext) {
292292
if (line.indexOf('#') >= 0) {
293293
line = line.substring(0, line.indexOf('#'));
294294
}
295-
var partitionEntry = partitionDataArray[i].split(",");
295+
var partitionEntry = line.split(",");
296296
if (partitionEntry.length > 4) {
297297
var offset = fancyParseInt(partitionEntry[3]);
298298
var length = fancyParseInt(partitionEntry[4]);

0 commit comments

Comments
 (0)