Warning: Patch file found for package X which is not present...

[pablopunk]

Hi, I have a repo with patch-package working fine but when another project has that repo as a dependency, the postinstall script tries to patch the node_modules under the first repo instead of the new one. i.e:

Here it works fine:

| my-lib/
--- package.json (with postinstall)
--- patches/

Here it doesn't:

| my-project/
--- package.json (with 'my-lib' as a dependency)

npm install throws: Warning: Patch file found for package X which is not present at ~my-project/node_modules/my-lib/node_modules/X which makes sense because it's not there, it's under ~/my-project/node_modules/X

[gabmontes]

I have the same issue using v5.1.1.

Is it supposed to be a supported scenario? This is: install a package that has patched dependencies and a prepare hook in its package.json and have patch-package to apply those. It looks like if/when dependencies are deduped, patch-package can't find the target package to apply the patches.

[ds300]

Hi! 👋 It is not safe to publish npm packages with patched dependencies (except devDependencies) so we don't support it.

…

On Wed, 6 Feb 2019 at 22:27 Gabriel Montes ***@***.***> wrote: I have the same issue using v5.1.1. Is it supposed to be a supported scenario? This is: install a package that has patched dependencies and a prepare hook in its package.json and have patch-package to apply those. It looks like if/when dependencies are deduped, patch-package can't find the target package to apply the patches. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#84 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABL1qRHaqHBmk6DO-WNm7chlKxUbbdpyks5vK1bjgaJpZM4WpfNG> .

[gabmontes]

@ds300 thanks for the clarification.

[bogas04]

One way to get around this would be to use prepare instead of postinstall to run patch-package, assuming your patches are only dev related (say patching certain @types/* for local dev).

[ahammond]

We are trying to use this is for a private leaf library which needs to monkey-patched one of it's deps until we can get an upstream fix merged. Disappointing that this is blocked. :(

[jamietanna]

Has anyone found a way to work around this?

I've also got a CLI that needs to patch a dependency, and trying to find a way to apply the patch 🤔