[BE][CI] bump ruff to 0.9.0: string quote styles (pytorch#144569)

Reference: https://docs.astral.sh/ruff/formatter/#f-string-formatting

- Change the outer quotes to double quotes for nested f-strings

```diff
- f'{", ".join(args)}'
+ f"{', '.join(args)}"
```

- Change the inner quotes to double quotes for triple f-strings

```diff
  string = """
-     {', '.join(args)}
+     {", ".join(args)}
  """
```

- Join implicitly concatenated strings

```diff
- string = "short string " "short string " f"{var}"
+ string = f"short string short string {var}"
```

Pull Request resolved: pytorch#144569
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#146509

Author: XuehaiPan

.ci/aarch64_linux/aarch64_wheel_ci_build.py

@@ -204,7 +204,7 @@ def parse_arguments():
         else:
             build_vars += f"BUILD_TEST=0 PYTORCH_BUILD_VERSION={version}.dev{build_date} PYTORCH_BUILD_NUMBER=1 "
     elif branch.startswith(("v1.", "v2.")):
-        build_vars += f"BUILD_TEST=0 PYTORCH_BUILD_VERSION={branch[1:branch.find('-')]} PYTORCH_BUILD_NUMBER=1 "
+        build_vars += f"BUILD_TEST=0 PYTORCH_BUILD_VERSION={branch[1 : branch.find('-')]} PYTORCH_BUILD_NUMBER=1 "
 
     if enable_mkldnn:
         build_ArmComputeLibrary()

.ci/aarch64_linux/build_aarch64_wheel.py

@@ -761,7 +761,7 @@ def start_build(
         version = host.check_output("cat pytorch/version.txt").strip()[:-2]
         build_vars += f"BUILD_TEST=0 PYTORCH_BUILD_VERSION={version}.dev{build_date} PYTORCH_BUILD_NUMBER=1"
     if branch.startswith(("v1.", "v2.")):
-        build_vars += f"BUILD_TEST=0 PYTORCH_BUILD_VERSION={branch[1:branch.find('-')]} PYTORCH_BUILD_NUMBER=1"
+        build_vars += f"BUILD_TEST=0 PYTORCH_BUILD_VERSION={branch[1 : branch.find('-')]} PYTORCH_BUILD_NUMBER=1"
     if host.using_docker():
         build_vars += " CMAKE_SHARED_LINKER_FLAGS=-Wl,-z,max-page-size=0x10000"
     if enable_mkldnn:

.ci/pytorch/smoke_test/max_autotune.py

@@ -46,7 +46,9 @@ def train(args, model, device, train_loader, optimizer, epoch):
         optimizer.step()
         if batch_idx % args.log_interval == 0:
             print(
-                f"Train Epoch: {epoch} [{batch_idx * len(data)}/{len(train_loader.dataset)} ({100. * batch_idx / len(train_loader):.0f}%)]\tLoss: {loss.item():.6f}"  # noqa: B950
+                f"Train Epoch: {epoch} "
+                f"[{batch_idx * len(data)}/{len(train_loader.dataset)} "
+                f"({100.0 * batch_idx / len(train_loader):.0f}%)]\tLoss: {loss.item():.6f}"
             )
             if args.dry_run:
                 break
@@ -71,7 +73,9 @@ def test(model, device, test_loader):
     test_loss /= len(test_loader.dataset)
 
     print(
-        f"\nTest set: Average loss: {test_loss:.4f}, Accuracy: {correct}/{len(test_loader.dataset)} ({100. * correct / len(test_loader.dataset):.0f}%)\n"  # noqa: B950
+        f"\nTest set: Average loss: {test_loss:.4f}, "
+        f"Accuracy: {correct}/{len(test_loader.dataset)} "
+        f"({100.0 * correct / len(test_loader.dataset):.0f}%)\n"
     )
 
 

.github/scripts/github_utils.py

@@ -57,10 +57,10 @@ def gh_fetch_url_and_headers(
             print(
                 f"""{url}
                 Rate limit exceeded:
-                Used: {err.headers['X-RateLimit-Used']}
-                Limit: {err.headers['X-RateLimit-Limit']}
-                Remaining: {err.headers['X-RateLimit-Remaining']}
-                Resets at: {err.headers['x-RateLimit-Reset']}"""
+                Used: {err.headers["X-RateLimit-Used"]}
+                Limit: {err.headers["X-RateLimit-Limit"]}
+                Remaining: {err.headers["X-RateLimit-Remaining"]}
+                Resets at: {err.headers["x-RateLimit-Reset"]}"""
             )
         else:
             print(f"Error fetching {url} {err}")

.github/scripts/trymerge.py

@@ -485,7 +485,7 @@ def get_check_run_name_prefix(workflow_run: Any) -> str:
     if workflow_run is None:
         return ""
     else:
-        return f'{workflow_run["workflow"]["name"]} / '
+        return f"{workflow_run['workflow']['name']} / "
 
 
 def is_passing_status(status: Optional[str]) -> bool:
@@ -545,7 +545,7 @@ def add_conclusions(edges: Any) -> None:
                     if not isinstance(checkrun_node, dict):
                         warn(f"Expected dictionary, but got {type(checkrun_node)}")
                         continue
-                    checkrun_name = f'{get_check_run_name_prefix(workflow_run)}{checkrun_node["name"]}'
+                    checkrun_name = f"{get_check_run_name_prefix(workflow_run)}{checkrun_node['name']}"
                     existing_checkrun = workflow_obj.jobs.get(checkrun_name)
                     if existing_checkrun is None or not is_passing_status(
                         existing_checkrun.status

.github/scripts/trymerge_explainer.py

@@ -79,7 +79,7 @@ def get_merge_message(
             (
                 "<details><summary>Advanced Debugging</summary>",
                 "Check the merge workflow status ",
-                f"<a href=\"{os.getenv('GH_RUN_URL')}\">here</a>",
+                f'<a href="{os.getenv("GH_RUN_URL")}">here</a>',
                 "</details>",
             )
         )

aten/src/ATen/native/transformers/cuda/flash_attn/kernels/generate_kernels.py

@@ -103,7 +103,7 @@ def main(output_dir: Optional[str]) -> None:
         "-o",
         "--output_dir",
         required=False,
-        help="Where to generate the kernels " " will default to the current directory ",
+        help="Where to generate the kernels will default to the current directory",
     )
     args = parser.parse_args()
     main(args.output_dir)

benchmarks/dynamo/check_accuracy.py

@@ -102,15 +102,15 @@ def check_accuracy(actual_csv, expected_csv, expected_filename):
             msg += textwrap.dedent(
                 f"""
             Error: {len(failed)} models have accuracy status regressed:
-                {' '.join(failed)}
+                {" ".join(failed)}
 
             """
             )
         if improved:
             msg += textwrap.dedent(
                 f"""
             Improvement: {len(improved)} models have accuracy status improved:
-                {' '.join(improved)}
+                {" ".join(improved)}
 
             """
             )

benchmarks/dynamo/check_csv.py

@@ -26,7 +26,7 @@ def check_csv(filename):
             textwrap.dedent(
                 f"""
                 Error {len(failed)} models failed
-                    {' '.join(failed)}
+                    {" ".join(failed)}
                 """
             )
         )

benchmarks/dynamo/check_graph_breaks.py

@@ -91,15 +91,15 @@ def check_graph_breaks(actual_csv, expected_csv, expected_filename):
             msg += textwrap.dedent(
                 f"""
             Error: {len(failed)} models have new dynamo graph breaks:
-                {' '.join(failed)}
+                {" ".join(failed)}
 
             """
             )
         if improved:
             msg += textwrap.dedent(
                 f"""
             Improvement: {len(improved)} models have fixed dynamo graph breaks:
-                {' '.join(improved)}
+                {" ".join(improved)}
 
             """
             )

benchmarks/dynamo/check_memory_compression_ratio.py

@@ -40,7 +40,7 @@ def main(args):
             textwrap.dedent(
                 f"""
                 Error: {len(failed)} models below expected memory compression ratio:
-                    {' '.join(failed)}
+                    {" ".join(failed)}
                 If this drop is expected, you can update `{args.expected}`.
                 """
             )

benchmarks/dynamo/check_perf_csv.py

@@ -26,7 +26,7 @@ def check_perf_csv(filename, threshold, threshold_scale):
             textwrap.dedent(
                 f"""
                 Error {len(failed)} models performance regressed
-                    {' '.join(failed)}
+                    {" ".join(failed)}
                 """
             )
         )

benchmarks/instruction_counts/core/api.py

@@ -368,7 +368,7 @@ def _model_from_py_stmt(
 
         return textwrap.dedent(
             f"""\
-            def model({', '.join(signature_args)}):
+            def model({", ".join(signature_args)}):
             {{stmt_str}}
                 return {signature_output}
         """
@@ -397,7 +397,7 @@ def _make_model_invocation(
             cpp_invocation = textwrap.dedent(
                 f"""\
                 std::vector<torch::jit::IValue> ivalue_inputs({{
-                    {', '.join([f'torch::jit::IValue({a})' for a in signature_args])}
+                    {", ".join([f"torch::jit::IValue({a})" for a in signature_args])}
                 }});
                 {cpp_prefix}{model_name}.forward(ivalue_inputs);
             """

docs/source/scripts/exportdb/generate_example_rst.py

@@ -49,7 +49,7 @@ def generate_example_rst(example_case: ExportCase):
     # Generate contents of the .rst file
     title = f"{example_case.name}"
     doc_contents = f"""{title}
-{'^' * (len(title))}
+{"^" * (len(title))}
 
 .. note::
 
@@ -117,7 +117,7 @@ def generate_index_rst(example_cases, tag_to_modules, support_level_to_modules):
         module_contents = "\n\n".join(v)
         support_contents += f"""
 {support_level}
-{'-' * (len(support_level))}
+{"-" * (len(support_level))}
 
 {module_contents}
 """

functorch/examples/dp_cifar10/cifar10_opacus.py

@@ -119,7 +119,7 @@ def test(args, model, test_loader, device):
 
     top1_avg = np.mean(top1_acc)
 
-    print(f"\tTest set:Loss: {np.mean(losses):.6f} Acc@1: {top1_avg :.6f} ")
+    print(f"\tTest set:Loss: {np.mean(losses):.6f} Acc@1: {top1_avg:.6f}")
     return np.mean(top1_acc)
 
 

functorch/examples/dp_cifar10/cifar10_transforms.py

@@ -185,7 +185,7 @@ def test(args, model, test_loader, device):
 
     top1_avg = np.mean(top1_acc)
 
-    print(f"\tTest set:Loss: {np.mean(losses):.6f} Acc@1: {top1_avg :.6f} ")
+    print(f"\tTest set:Loss: {np.mean(losses):.6f} Acc@1: {top1_avg:.6f}")
     return np.mean(top1_acc)
 
 

scripts/compile_tests/failures_histogram.py

@@ -108,7 +108,7 @@ def failures_histogram(eager_dir, dynamo_dir, verbose=False, format_issues=False
 def as_issue(count, msg, repro, tests):
     tests = "\n".join(tests)
     result = f"""
-{'-' * 50}
+{"-" * 50}
 {count} Dynamo test are failing with \"{msg}\".
 
 ## Repro

scripts/release_notes/categorize.py

@@ -145,7 +145,7 @@ def handle_commit(self, commit, i, total, commits):
 
 Current category: {commit.category}
 
-Select from: {', '.join(common.categories)}
+Select from: {", ".join(common.categories)}
 
         """
         )
@@ -165,7 +165,7 @@ def handle_commit(self, commit, i, total, commits):
             cat_choice = choices[0]
         print(f"\nSelected: {cat_choice}")
         print(f"\nCurrent topic: {commit.topic}")
-        print(f"""Select from: {', '.join(topics)}""")
+        print(f"""Select from: {", ".join(topics)}""")
         topic_choice = None
         while topic_choice is None:
             value = input("topic> ").strip()

setup.py

@@ -1454,8 +1454,7 @@ def main():
         name=package_name,
         version=version,
         description=(
-            "Tensors and Dynamic neural networks in "
-            "Python with strong GPU acceleration"
+            "Tensors and Dynamic neural networks in Python with strong GPU acceleration"
         ),
         long_description=long_description,
         long_description_content_type="text/markdown",

test/run_test.py

@@ -759,7 +759,7 @@ def run_test(
         stepcurrent_key = f"{test_file}_{test_module.shard}_{os.urandom(8).hex()}"
 
     if options.verbose:
-        unittest_args.append(f'-{"v" * options.verbose}')  # in case of pytest
+        unittest_args.append(f"-{'v' * options.verbose}")  # in case of pytest
 
     if test_file in RUN_PARALLEL_BLOCKLIST:
         unittest_args = [
@@ -1895,8 +1895,7 @@ def get_selected_tests(options) -> list[str]:
         selected_tests = exclude_tests(
             TESTS_NOT_USING_GRADCHECK,
             selected_tests,
-            "Running in slow gradcheck mode, skipping tests "
-            "that don't use gradcheck.",
+            "Running in slow gradcheck mode, skipping tests that don't use gradcheck.",
             exact_match=True,
         )
 

test/test_dispatch.py

@@ -151,7 +151,7 @@ def check_invariants(actual_provenance):
             active_ops.add(op_ix)
             try:
                 ops[op_ix](refs[op_ix])
-                check_invariants(f"running ctors {ctor_order[:i + 1]}")
+                check_invariants(f"running ctors {ctor_order[: i + 1]}")
             except RuntimeError as e:
                 if not expect_raises:
                     raise
@@ -160,7 +160,7 @@ def check_invariants(actual_provenance):
                 expected, _, expected_provenance = results.setdefault(
                     frozenset(active_ops),
                     Result(
-                        actual, "", f"error after running ctors {ctor_order[:i + 1]}"
+                        actual, "", f"error after running ctors {ctor_order[: i + 1]}"
                     ),
                 )
                 self.assertMultiLineEqual(expected, actual, expected_provenance)
@@ -195,7 +195,7 @@ def check_invariants(actual_provenance):
             else:
                 active_ops.remove(op_ix)
             check_invariants(
-                f"running ctors {ctor_order[:last_ctor + 1]}, then running dtors {dtor_order[:i + 1]}"
+                f"running ctors {ctor_order[: last_ctor + 1]}, then running dtors {dtor_order[: i + 1]}"
             )
         return results[set_to_report][0]
 

test/test_jit_fuser_te.py

@@ -2878,8 +2878,8 @@ def te_compile(self, device, dtype, op):
                     fx_args.append(f"{k} = {repr(v)}")
 
             code = f"""
-def f({', '.join(param_names)}):
-    return op.op({', '.join(fx_args)})"""
+def f({", ".join(param_names)}):
+    return op.op({", ".join(fx_args)})"""
             g = {"torch": torch, "inf": math.inf, "op": op}
             exec(code, g)
             f = g["f"]

tools/autograd/gen_inplace_or_view_type.py

@@ -575,7 +575,7 @@ def gen_formals(f: NativeFunction) -> str:
         # See Note [Plumbing Keys Through The Dispatcher] for details.
         ["c10::DispatchKeySet ks"]
         + [
-            f'{cpp.argument_type(a, binds="__placeholder__", symint=True).cpp_type()} {a.name}'
+            f"{cpp.argument_type(a, binds='__placeholder__', symint=True).cpp_type()} {a.name}"
             for a in f.func.schema_order_arguments()
         ]
     )

tools/autograd/gen_python_functions.py

@@ -723,7 +723,7 @@ def emit_structseq_call(
         tn_key = gen_structseq_typename_key(overload.function)
         typename = typenames.get(tn_key)
         if typename is None:
-            typename = f'NamedTuple{"" if not typedefs else len(typedefs)}'
+            typename = f"NamedTuple{'' if not typedefs else len(typedefs)}"
             typenames[tn_key] = typename
             typedefs.append(
                 f"""\
@@ -759,7 +759,7 @@ def generate_return_type_definition_and_registrations(
         typename = typenames.get(tn_key)
 
         if typename is None:
-            typename = f'{name}NamedTuple{"" if not definitions else len(definitions)}'
+            typename = f"{name}NamedTuple{'' if not definitions else len(definitions)}"
             typenames[tn_key] = typename
             definitions.append(
                 f"""\
@@ -807,7 +807,7 @@ def generate_return_type_declarations(
 
         if typename is None:
             typename = (
-                f'{name}NamedTuple{"" if not declarations else len(declarations)}'
+                f"{name}NamedTuple{'' if not declarations else len(declarations)}"
             )
             typenames[tn_key] = typename
             declarations.append(f"PyTypeObject* get_{name}_structseq();")
@@ -1351,7 +1351,7 @@ def go(f: NativeFunction) -> str:
             or (ps.method and ("requires_grad" in parser_outputs))
         )
         set_requires_grad = (
-            f'.set_requires_grad({parser_outputs["requires_grad"].expr})'
+            f".set_requires_grad({parser_outputs['requires_grad'].expr})"
             if need_set_requires_grad
             else ""
         )

tools/autograd/gen_trace_type.py

@@ -381,17 +381,17 @@ def format_postrecord_trace(f: NativeFunction) -> str:
 
 def tie_return_values(f: NativeFunction) -> str:
     if len(f.func.returns) == 1:
-        return f'auto {f.func.returns[0].name or "result"}'
+        return f"auto {f.func.returns[0].name or 'result'}"
     names = cpp.return_names(f)
-    return f'auto [{", ".join(names)}]'
+    return f"auto [{', '.join(names)}]"
 
 
 def get_return_value(f: NativeFunction) -> str:
     names = cpp.return_names(f)
     if len(f.func.returns) == 1:
         return names[0]
     if f.func.kind() == SchemaKind.out:
-        return f'std::forward_as_tuple({", ".join(names)})'
+        return f"std::forward_as_tuple({', '.join(names)})"
     else:
         moved = ", ".join(f"std::move({name})" for name in names)
         return f"std::make_tuple({moved})"
@@ -474,7 +474,7 @@ def method_definition(f: NativeFunction) -> str:
         # See Note [Plumbing Keys Through The Dispatcher] for details.
         ["c10::DispatchKeySet ks"]
         + [
-            f'{cpp.argument_type(a, binds="__placeholder__", symint=True).cpp_type()} {a.name}'
+            f"{cpp.argument_type(a, binds='__placeholder__', symint=True).cpp_type()} {a.name}"
             for a in f.func.schema_order_arguments()
         ]
     )

tools/autograd/gen_variable_factories.py

@@ -108,9 +108,9 @@ def process_function(f: NativeFunction) -> str | None:
                 exprs.append(arg.name)
 
         r += f"""\
-inline at::Tensor {sig.name()}({', '.join(formals)}) {{
+inline at::Tensor {sig.name()}({", ".join(formals)}) {{
   at::AutoDispatchBelowADInplaceOrView guard;
-  return autograd::make_variable(at::{sig.name()}({', '.join(exprs)}), /*requires_grad=*/{requires_grad});
+  return autograd::make_variable(at::{sig.name()}({", ".join(exprs)}), /*requires_grad=*/{requires_grad});
 }}
 """
     return r