calls to array_idx_modifiable that require space allocation changed to array_idx_get_space

Author: Sergey-Kitov

src/client-state.c

@@ -1002,7 +1002,7 @@ bool imap_client_get_random_seq_range(struct imap_client *client,
 	msgs = array_count(&client->view->uidmap);
 	for (i = tries = 0; i < count && tries < count*3; tries++) {
 		seq = i_rand() % msgs + 1;
-		metadata = array_idx_modifiable(&client->view->messages,
+		metadata = array_idx_get_space(&client->view->messages,
 						seq - 1);
 		owner = metadata->ms == NULL ? 0 :
 			metadata->ms->owner_client_idx1;

src/client.c

@@ -187,7 +187,7 @@ struct client *client_new_user(struct user *user)
 	if (!user_get_new_client_profile(user, &uc))
 		return NULL;
 	while (client_min_free_idx < conf.clients_count) {
-		clientp = array_idx_modifiable(&clients, client_min_free_idx);
+		clientp = array_idx_get_space(&clients, client_min_free_idx);
 		if (*clientp == NULL)
 			return client_new_full(client_min_free_idx, user, uc);
 		client_min_free_idx++;

src/imap-client.c

@@ -100,7 +100,7 @@ static int imap_client_expunge(struct imap_client *client, unsigned int seq)
 		return -1;
 	}
 
-	metadata = array_idx_modifiable(&client->view->messages, seq - 1);
+	metadata = array_idx_get_space(&client->view->messages, seq - 1);
 	if (metadata->fetch_refcount > 0) {
 		imap_client_input_error(client,
 			"Referenced message expunged seq=%u uid=%u",

src/mailbox-state.c

@@ -519,7 +519,7 @@ void mailbox_state_handle_fetch(struct imap_client *client, unsigned int seq,
 	}
 	uid = *uidp;
 
-	metadata = array_idx_modifiable(&view->messages, seq - 1);
+	metadata = array_idx_get_space(&view->messages, seq - 1);
 	if (metadata->ms == NULL && uid != 0) {
 		metadata->ms =
 			message_metadata_static_get(client->storage, uid);

src/test-exec.c

@@ -602,8 +602,8 @@ test_handle_untagged_match(struct imap_client *client, const struct imap_arg *ar
 	array_clear(&ctx->added_variables);
 	found = buffer_get_space_unsafe(ctx->cur_received_untagged, 0, count);
 	if (count > 0)
-		(void)array_idx_modifiable(&ctx->cur_maybe_matches, count-1);
-	maybes = array_idx_modifiable(&ctx->cur_maybe_matches, 0);
+		(void)array_idx_get_space(&ctx->cur_maybe_matches, count-1);
+	maybes = array_idx_get_space(&ctx->cur_maybe_matches, 0);
 	found_some = FALSE;
 	for (i = 0; i < count; i++) {
 		if (found[i] != 0)

src/test-parser.c

@@ -65,7 +65,7 @@ test_parse_header_line(struct test_parser *parser, struct test *test,
 			test->require_user2 = TRUE;
 			value = conf.username2_template;
 		}
-		test_conn = array_idx_modifiable(&test->connections, idx-1);
+		test_conn = array_idx_get_space(&test->connections, idx-1);
 		test_conn->username = p_strdup(parser->pool, value);
 		return TRUE;
 	}