-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Summary
Currently, the mono packs workload doesn't properly calculate the unique hash value that we use when creating a unique URL for the VS drop upload. This causes the (biggest) workload to be uploaded multiple times (per servicing branch count). It will emit this many, many times in the build log:
Exception calling "Write" with "1" argument(s): "Exception of type 'System.OutOfMemoryException' was thrown."
At D:\a\_work\1\s\eng\create-workload-drops.ps1:35 char:76
+ ... t-Content -Encoding ASCII -Raw | ForEach-Object { $writer.Write($_) }
+ ~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (:) [], MethodInvocationException
+ FullyQualifiedErrorId : OutOfMemoryException
Basically, the algo is collecting the contents of all of the files in the workload, then creating the hash. This obviously doesn't work if there is too much content in a single workload. The algo would need to be changed so that:
- Each file is individually hashed
- Then calculate the hash of hashes
If this change is done, it needs to be done on all branches. Otherwise, different calculations on different branches would invalidate the point of the hash.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working