Skip to content

Update references for .NET 10 #51925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

Update references for .NET 10 #51925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Layout/redist/targets/GenerateBundledVersions.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@
<_NETCorePlatformsPackageVersion>$(MicrosoftNETCorePlatformsPackageVersion)</_NETCorePlatformsPackageVersion>

<!-- TODO: Once .NET 10.0.X has released, update these version numbers to 10.0.$(VersionFeature100) -->
<_NET100RuntimePackVersion>10.0.100-preview.7.25380.108</_NET100RuntimePackVersion>
<_NET100TargetingPackVersion>10.0.100-preview.7.25380.108</_NET100TargetingPackVersion>
<_WindowsDesktop100RuntimePackVersion>10.0.0-preview.7.25380.108</_WindowsDesktop100RuntimePackVersion>
<_WindowsDesktop100TargetingPackVersion>10.0.0-preview.7.25380.108</_WindowsDesktop100TargetingPackVersion>
<_AspNet100RuntimePackVersion>10.0.0-preview.7.25380.108</_AspNet100RuntimePackVersion>
<_AspNet100TargetingPackVersion>10.0.0-preview.7.25380.108</_AspNet100TargetingPackVersion>
<_NET100RuntimePackVersion>10.0.100-rtm.25523.111</_NET100RuntimePackVersion>
<_NET100TargetingPackVersion>10.0.100-rtm.25523.111</_NET100TargetingPackVersion>
<_WindowsDesktop100RuntimePackVersion>10.0.100-rtm.25523.111</_WindowsDesktop100RuntimePackVersion>
<_WindowsDesktop100TargetingPackVersion>10.0.100-rtm.25523.111</_WindowsDesktop100TargetingPackVersion>
<_AspNet100RuntimePackVersion>10.0.100-rtm.25523.111</_AspNet100RuntimePackVersion>
<_AspNet100TargetingPackVersion>10.0.100-rtm.25523.111</_AspNet100TargetingPackVersion>
Comment on lines +90 to +93
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number pattern is inconsistent. Based on Version.Details.xml (lines 41, 249, 261 in eng/Version.Details.xml), all .NET 10 packages use 10.0.0 as their base version, not 10.0.100:

  • Microsoft.NETCore.App.Ref: 10.0.0-rc.3.25567.101
  • Microsoft.WindowsDesktop.App.Ref: 10.0.0-rc.3.25567.101
  • Microsoft.AspNetCore.App.Ref: 10.0.0-rc.3.25567.101

While _NET100RuntimePackVersion and _NET100TargetingPackVersion could reasonably use 10.0.100 to match SDK versioning patterns, _WindowsDesktop100RuntimePackVersion, _WindowsDesktop100TargetingPackVersion, _AspNet100RuntimePackVersion, and _AspNet100TargetingPackVersion should use 10.0.0 to match the actual package versions.

The previous code had this correct (10.0.0 for WindowsDesktop/AspNet), and this appears to be an unintended change.

Suggested change
<_WindowsDesktop100RuntimePackVersion>10.0.100-rtm.25523.111</_WindowsDesktop100RuntimePackVersion>
<_WindowsDesktop100TargetingPackVersion>10.0.100-rtm.25523.111</_WindowsDesktop100TargetingPackVersion>
<_AspNet100RuntimePackVersion>10.0.100-rtm.25523.111</_AspNet100RuntimePackVersion>
<_AspNet100TargetingPackVersion>10.0.100-rtm.25523.111</_AspNet100TargetingPackVersion>
<_WindowsDesktop100RuntimePackVersion>10.0.0-rtm.25523.111</_WindowsDesktop100RuntimePackVersion>
<_WindowsDesktop100TargetingPackVersion>10.0.0-rtm.25523.111</_WindowsDesktop100TargetingPackVersion>
<_AspNet100RuntimePackVersion>10.0.0-rtm.25523.111</_AspNet100RuntimePackVersion>
<_AspNet100TargetingPackVersion>10.0.0-rtm.25523.111</_AspNet100TargetingPackVersion>

Copilot uses AI. Check for mistakes.

<_NET90RuntimePackVersion>9.0.$(VersionFeature90)</_NET90RuntimePackVersion>
<_NET90TargetingPackVersion>9.0.$(VersionFeature90)</_NET90TargetingPackVersion>
Expand Down