Skip to content

Conversation

@DonnaChen888
Copy link
Contributor

Related to #50295.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates .NET 10 package version references from preview builds to RTM builds. It's part of the preparation for the .NET 10 release, updating six package version properties used for bundling .NET 10 runtime, targeting, and framework packs.

Key Changes

  • Updates all .NET 10 package versions from preview.7.25380.108 to rtm.25523.111
  • Changes affect runtime and targeting pack versions for Microsoft.NETCore.App, Microsoft.WindowsDesktop.App, and Microsoft.AspNetCore.App frameworks
  • All six version properties are now unified to use 10.0.100 as the base version

Comment on lines +90 to +93
<_WindowsDesktop100RuntimePackVersion>10.0.100-rtm.25523.111</_WindowsDesktop100RuntimePackVersion>
<_WindowsDesktop100TargetingPackVersion>10.0.100-rtm.25523.111</_WindowsDesktop100TargetingPackVersion>
<_AspNet100RuntimePackVersion>10.0.100-rtm.25523.111</_AspNet100RuntimePackVersion>
<_AspNet100TargetingPackVersion>10.0.100-rtm.25523.111</_AspNet100TargetingPackVersion>
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number pattern is inconsistent. Based on Version.Details.xml (lines 41, 249, 261 in eng/Version.Details.xml), all .NET 10 packages use 10.0.0 as their base version, not 10.0.100:

  • Microsoft.NETCore.App.Ref: 10.0.0-rc.3.25567.101
  • Microsoft.WindowsDesktop.App.Ref: 10.0.0-rc.3.25567.101
  • Microsoft.AspNetCore.App.Ref: 10.0.0-rc.3.25567.101

While _NET100RuntimePackVersion and _NET100TargetingPackVersion could reasonably use 10.0.100 to match SDK versioning patterns, _WindowsDesktop100RuntimePackVersion, _WindowsDesktop100TargetingPackVersion, _AspNet100RuntimePackVersion, and _AspNet100TargetingPackVersion should use 10.0.0 to match the actual package versions.

The previous code had this correct (10.0.0 for WindowsDesktop/AspNet), and this appears to be an unintended change.

Suggested change
<_WindowsDesktop100RuntimePackVersion>10.0.100-rtm.25523.111</_WindowsDesktop100RuntimePackVersion>
<_WindowsDesktop100TargetingPackVersion>10.0.100-rtm.25523.111</_WindowsDesktop100TargetingPackVersion>
<_AspNet100RuntimePackVersion>10.0.100-rtm.25523.111</_AspNet100RuntimePackVersion>
<_AspNet100TargetingPackVersion>10.0.100-rtm.25523.111</_AspNet100TargetingPackVersion>
<_WindowsDesktop100RuntimePackVersion>10.0.0-rtm.25523.111</_WindowsDesktop100RuntimePackVersion>
<_WindowsDesktop100TargetingPackVersion>10.0.0-rtm.25523.111</_WindowsDesktop100TargetingPackVersion>
<_AspNet100RuntimePackVersion>10.0.0-rtm.25523.111</_AspNet100RuntimePackVersion>
<_AspNet100TargetingPackVersion>10.0.0-rtm.25523.111</_AspNet100TargetingPackVersion>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants