dotnet format fails

[devsko]

dotnet format fails in 10.0.100-preview.5.25277.114 with .slnx solutions.
(This worked in preview 4)

Unhandled exception: System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.VisualStudio.SolutionPersistence, Version=1.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Das System kann die angegebene Datei nicht finden.
File name: 'Microsoft.VisualStudio.SolutionPersistence, Version=1.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
   at Microsoft.Build.Construction.SolutionFile.ParseUsingNewParser()
   at Microsoft.Build.Construction.SolutionFile.ParseUsingNewParser()
   at Microsoft.Build.Construction.SolutionFile.Parse(String solutionFile)
   at Microsoft.CodeAnalysis.MSBuild.MSBuildProjectLoader.LoadSolutionInfoAsync(String solutionFilePath, IProgress`1 progress, ILogger msbuildLogger, CancellationToken cancellationToken)
   at Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace.OpenSolutionAsync(String solutionFilePath, ILogger msbuildLogger, IProgress`1 progress, CancellationToken cancellationToken)
   at Microsoft.CodeAnalysis.Tools.Workspaces.MSBuildWorkspaceLoader.LoadAsync(String solutionOrProjectPath, WorkspaceType workspaceType, String binaryLogPath, Boolean logWorkspaceWarnings, ILogger logger, CancellationToken cancellationToken)
   at Microsoft.CodeAnalysis.Tools.CodeFormatter.OpenMSBuildWorkspaceAsync(String solutionOrProjectPath, WorkspaceType workspaceType, Boolean noRestore, Boolean requiresSemantics, String binaryLogPath, Boolean logWorkspaceWarnings, ILogger logger, CancellationToken cancellationToken)
   at Microsoft.CodeAnalysis.Tools.CodeFormatter.FormatWorkspaceAsync(FormatOptions formatOptions, ILogger logger, CancellationToken cancellationToken, String binaryLogPath)
   at Microsoft.CodeAnalysis.Tools.FormatCommandCommon.FormatAsync(FormatOptions formatOptions, ILogger`1 logger, CancellationToken cancellationToken)
   at Microsoft.CodeAnalysis.Tools.Commands.RootFormatCommand.FormatCommandDefaultHandler.InvokeAsync(ParseResult parseResult, CancellationToken cancellationToken)
   at System.CommandLine.Invocation.InvocationPipeline.InvokeAsync(ParseResult parseResult, CancellationToken cancellationToken)

[WeihanLi]

same issue +1

[baronfel]

@dotnet/format-owners is there a dependency bump that needs to happen for the roslyn msbuildworkspace library that we can get fixed for p6?

[JoeRobich]

is there a dependency bump that needs to happen for the roslyn msbuildworkspace library that we can get fixed for p6?

It appears that the version in the main branch includes our change for MSBuildWorkspace to use the vs-solutionpersistence library directly to parse solution files instead of relying on the loaded MSBuild to do the parsing.

[baronfel]

perfect - so for p5, format can't be used for slnx but from p6 onwards we should be good?

[JoeRobich]

Yes, we ship vs-solutionpersistence with the MSBuildWorkspaces library, so there should be no problem locating it. The fact it can't be used on p5 surprises me but, as dotnet-format relies on MSBuildLocator, it is possible we aren't locating vs-solutionpersistence from the MSBuild folder.

[WeihanLi]

Is there any workaround for the issue?

[JoeRobich]

Is there any workaround for the issue?

@WeihanLi I imagine you could copy the Microsoft.VisualStudio.SolutionPersistence.dll from the root of the SDK folder into the /DotnetTools/dotnet-format folder. However, I would just consider dotnet-format busted for slnx in preview 5. SLNX support has been tracked by dotnet/format#2225