Simplify Uri's CreateHelper #122002
Open
Simplify Uri's CreateHelper #122002
+23
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
Copilot finished reviewing on behalf of
MihaZupan
November 26, 2025 21:08
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the CreateHelper method and its call sites in the Uri class by refactoring exception handling and consolidating null checks. The changes maintain behavioral equivalence while improving code clarity and following modern C# patterns.
Key Changes:
- Removed the
ref UriFormatException? eparameter fromCreateHelper, moving exception handling entirely within the method - Consolidated null checks for
uriStringintoCreateHelperitself, eliminating redundant checks at call sites - Modernized the
UriKindrange validation to use pattern matching syntax
MihaZupan
force-pushed
the
uri-sharedInit3
branch
from
7c194a2 to
736ca04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same idea as #122001 - simplifications without behavioral changes to make future changes easier to review.
In this case there's no need to flow around the exception argument if all callers just care about a yes/no.