Remove DOTNET_MULTILEVEL_LOOKUP environment variable settings #122051
+6
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jkotas <[email protected]>
Copilot
AI
changed the title
[WIP] Remove logic for multi-level lookup
Remove DOTNET_MULTILEVEL_LOOKUP environment variable settings
Nov 29, 2025
Copilot finished work on behalf of
jkotas
November 29, 2025 01:57
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
jkotas
approved these changes
Nov 29, 2025
Copilot finished reviewing on behalf of
jkotas
November 29, 2025 01:59
Contributor
There was a problem hiding this comment.
Pull request overview
This PR systematically removes the DOTNET_MULTILEVEL_LOOKUP environment variable setting from build scripts, test infrastructure, and development environment configurations throughout the repository. The variable no longer serves any functional purpose and its removal simplifies the codebase.
Key Changes
- Removed
DOTNET_MULTILEVEL_LOOKUP=0settings from build and test scripts - Cleaned up devcontainer JSON configuration files
- Updated Python scripts used for SuperPMI benchmarking
Reviewed changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet.cmd | Removed DOTNET_MULTILEVEL_LOOKUP setting from Windows dotnet wrapper script |
| dotnet.sh | Removed DOTNET_MULTILEVEL_LOOKUP setting from Unix dotnet wrapper script |
| eng/build.ps1 | Removed DOTNET_MULTILEVEL_LOOKUP setting from main PowerShell build script |
| eng/common/tools.ps1 | Removed DOTNET_MULTILEVEL_LOOKUP setting and pipeline variable (2 locations) |
| eng/common/tools.sh | Removed DOTNET_MULTILEVEL_LOOKUP setting and pipeline variable (2 locations) |
| eng/testing/RunnerTemplate.cmd | Removed DOTNET_MULTILEVEL_LOOKUP setting from Windows test runner template |
| eng/testing/RunnerTemplate.sh | Removed DOTNET_MULTILEVEL_LOOKUP setting from Unix test runner template |
| eng/pipelines/common/macos-sign-with-entitlements.yml | Removed DOTNET_MULTILEVEL_LOOKUP from macOS signing pipeline environment |
| src/coreclr/scripts/superpmi_aspnet.py | Removed DOTNET_MULTILEVEL_LOOKUP from SuperPMI aspnet benchmarking script |
| src/coreclr/scripts/superpmi_aspnet2.py | Removed DOTNET_MULTILEVEL_LOOKUP from SuperPMI aspnet2 benchmarking script |
| src/libraries/Common/tests/System/Net/StressTests/build-local.ps1 | Removed DOTNET_MULTILEVEL_LOOKUP from stress test build script |
| src/libraries/Common/tests/System/Net/StressTests/build-local.sh | Removed DOTNET_MULTILEVEL_LOOKUP from Unix stress test build script |
| src/libraries/System.Net.Http/tests/StressTests/HttpStress/load-corefx-testhost.ps1 | Removed DOTNET_MULTILEVEL_LOOKUP and fixed trailing whitespace |
| src/mono/wasm/Wasm.Build.Tests/Common/BuildEnvironment.cs | Removed DOTNET_MULTILEVEL_LOOKUP from WASM test build environment configuration |
| src/mono/wasm/Wasm.Build.Tests/Common/RunCommand.cs | Removed DOTNET_MULTILEVEL_LOOKUP from WASM test run command |
| src/mono/wasm/Wasm.Build.Tests/Common/ToolCommand.cs | Removed DOTNET_MULTILEVEL_LOOKUP from WASM test tool command environment |
| .devcontainer/devcontainer.json | Removed DOTNET_MULTILEVEL_LOOKUP from standard devcontainer environment |
| .devcontainer/android/devcontainer.json | Removed DOTNET_MULTILEVEL_LOOKUP from Android devcontainer environment |
| .devcontainer/libraries/devcontainer.json | Removed DOTNET_MULTILEVEL_LOOKUP from libraries devcontainer environment |
| .devcontainer/wasm/devcontainer.json | Removed DOTNET_MULTILEVEL_LOOKUP from WASM devcontainer environment |
| .devcontainer/wasm-multiThreaded/devcontainer.json | Removed DOTNET_MULTILEVEL_LOOKUP from multi-threaded WASM devcontainer environment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOTNET_MULTILEVEL_LOOKUPhas been non-functional for multiple releases. This removes all code that sets this environment variable throughout the repo.Addresses #121327
Changes
Build infrastructure:
dotnet.sh,dotnet.cmdeng/build.ps1eng/common/tools.sh,eng/common/tools.ps1eng/testing/RunnerTemplate.sh,eng/testing/RunnerTemplate.cmdeng/pipelines/common/macos-sign-with-entitlements.ymlDevcontainer configs:
.devcontainer/*/devcontainer.jsonfilesTest infrastructure:
src/mono/wasm/Wasm.Build.Tests/Common/{RunCommand,BuildEnvironment,ToolCommand}.cssrc/coreclr/scripts/superpmi_aspnet.py,superpmi_aspnet2.pysrc/libraries/Common/tests/System/Net/StressTests/build-local.{sh,ps1}src/libraries/System.Net.Http/tests/StressTests/HttpStress/load-corefx-testhost.ps1Not modified
src/installer/tests/TestUtils/Constants.cs— defines constant for test utilitiessrc/native/corehost/hostmisc/utils.cpp— reads the variable (host implementation)docs/design/features/host-component-dependencies-resolution.md— documentationOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.