Skip to content

System.Diagnostics.Metrics out of proc monitoring improved histogram support #109388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #109396
CodeBlanch opened this issue Oct 30, 2024 · 1 comment · May be fixed by #115852
Open
Tracked by #109396

System.Diagnostics.Metrics out of proc monitoring improved histogram support #109388

CodeBlanch opened this issue Oct 30, 2024 · 1 comment · May be fixed by #115852

Comments

@CodeBlanch
Copy link
Contributor

Today when listening to metrics via MetricsEventSource histograms are represented as OpenTelemetry summary metrics (more or less).

Summary metrics work well with Prometheus but aren't as well-supported or feature rich as explicit bucket histograms or base2 exponential histograms.

Requesting for .NET 10 we add the ability to opt-into additional histogram types.

Don't have a design yet. Only thoughts...

  • Explicit bucket histograms

    • Users should be able to specify custom buckets...
    • Else advice buckets should be respected...
    • Else default buckets should be used.
  • Base2 exponential histograms

    • Users should be able to specify MaxSize and MaxScale...
    • Else defaults should be used.

Do we need both? Base2 exponential histogram is the more flexible type as it dynamically adjusts to the values. But it is a newer thing and may not be supported by enough backends to be generally useful.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 30, 2024
@tarekgh tarekgh added this to the 10.0.0 milestone Oct 30, 2024
@tarekgh tarekgh removed the untriaged New issue has not been triaged by the area owner label Oct 30, 2024
@tarekgh tarekgh mentioned this issue Oct 31, 2024
14 tasks
@rajkumar-rangaraj
Copy link

Supporting two types of histograms current default and e2 should be sufficient for .NET 10. The new e2 histogram could be an opt-in. Additional histogram types can be considered in the future based on demand raised through the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants