diff --git a/eng/Packages.props b/eng/Packages.props index 0b85f2c0dcd..ac8df77f629 100644 --- a/eng/Packages.props +++ b/eng/Packages.props @@ -19,7 +19,6 @@ - diff --git a/eng/SourceBuildPrebuiltBaseline.xml b/eng/SourceBuildPrebuiltBaseline.xml index c27e7fdbc16..73a2dd31105 100644 --- a/eng/SourceBuildPrebuiltBaseline.xml +++ b/eng/SourceBuildPrebuiltBaseline.xml @@ -4,16 +4,13 @@ - - - - + diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 3a604bf66c8..40db7faeb74 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -14,9 +14,9 @@ - - https://dev.azure.com/dnceng/internal/_git/dotnet-runtime - 5535e31a712343a63f5d7d796cd874e563e5ac14 + + https://github.com/dotnet/runtime + d099f075e45d2aa6007a22b71b45a08758559f80 @@ -52,17 +52,13 @@ https://github.com/dotnet/runtime d099f075e45d2aa6007a22b71b45a08758559f80 - - https://dev.azure.com/dnceng/internal/_git/dotnet-runtime - 81cabf2857a01351e5ab578947c7403a5b128ad1 - - - https://dev.azure.com/dnceng/internal/_git/dotnet-runtime - 2aade6beb02ea367fd97c4070a4198802fe61c03 + + https://github.com/dotnet/runtime + 5b20af47d99620150c53eaf5db8636fdf730b126 - + https://github.com/dotnet/arcade c7a36e53f91e41943746f97a8c183549364c5092 @@ -86,4 +82,4 @@ c7a36e53f91e41943746f97a8c183549364c5092 - + \ No newline at end of file diff --git a/eng/Versions.props b/eng/Versions.props index 367f906bc2a..89e6542336a 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -2,7 +2,7 @@ - 17.8.26 + 17.8.29 release 17.7.0 15.1.0.0 @@ -27,9 +27,8 @@ - 8.0.0 + 7.0.0 7.0.0 - 8.0.1 @@ -68,8 +68,8 @@ - - + + @@ -94,8 +94,8 @@ - - + + @@ -129,13 +129,13 @@ - - + + - - + + @@ -229,4 +229,4 @@ - + \ No newline at end of file diff --git a/src/MSBuild/app.config b/src/MSBuild/app.config index fcf5a7a524d..d8320fd2a47 100644 --- a/src/MSBuild/app.config +++ b/src/MSBuild/app.config @@ -41,11 +41,7 @@ - - - - - + @@ -62,7 +58,7 @@ - + @@ -90,11 +86,11 @@ - + - + @@ -182,4 +178,4 @@ - + \ No newline at end of file diff --git a/src/Tasks.UnitTests/MSBuild_Tests.cs b/src/Tasks.UnitTests/MSBuild_Tests.cs index f8dcf89bbfe..78e99d99f1e 100644 --- a/src/Tasks.UnitTests/MSBuild_Tests.cs +++ b/src/Tasks.UnitTests/MSBuild_Tests.cs @@ -389,7 +389,7 @@ public void LogErrorWhenBuildingVCProj() #if RUNTIME_TYPE_NETCORE [Fact(Skip = "https://github.com/dotnet/msbuild/issues/259")] #else - [Fact] + [Fact(Skip = "https://github.com/dotnet/msbuild/issues/11888")] #endif public void PropertyOverridesContainSemicolon() { diff --git a/src/Tasks.UnitTests/ResourceHandling/GenerateResourceOutOfProc_Tests.cs b/src/Tasks.UnitTests/ResourceHandling/GenerateResourceOutOfProc_Tests.cs index 4172d013c78..6ccb9f0854f 100644 --- a/src/Tasks.UnitTests/ResourceHandling/GenerateResourceOutOfProc_Tests.cs +++ b/src/Tasks.UnitTests/ResourceHandling/GenerateResourceOutOfProc_Tests.cs @@ -2566,7 +2566,7 @@ public References(ITestOutputHelper output) _output = output; } - [Fact] + [Fact(Skip = "https://github.com/dotnet/msbuild/issues/11888")] // FIXME: mono: looks for csc.exe // https://github.com/dotnet/msbuild/issues/677 public void DontLockP2PReferenceWhenResolvingSystemTypes() @@ -2743,7 +2743,7 @@ public class Class1 /// Assembly.LoadFile on that relative path, which fails (LoadFile requires an /// absolute path). The fix was to use Assembly.LoadFrom instead. /// - [Fact] + [Fact(Skip = "https://github.com/dotnet/msbuild/issues/11888")] // FIXME: mono: looks for csc.exe // https://github.com/dotnet/msbuild/issues/677 public void ReferencedAssemblySpecifiedUsingRelativePath() diff --git a/src/Tasks.UnitTests/ResourceHandling/GenerateResource_Tests.cs b/src/Tasks.UnitTests/ResourceHandling/GenerateResource_Tests.cs index f704ef169a1..68a707586e2 100644 --- a/src/Tasks.UnitTests/ResourceHandling/GenerateResource_Tests.cs +++ b/src/Tasks.UnitTests/ResourceHandling/GenerateResource_Tests.cs @@ -3010,7 +3010,7 @@ public References(ITestOutputHelper output) _output = output; } - [WindowsFullFrameworkOnlyFact(additionalMessage: "Linked resources not supported on Core: https://github.com/dotnet/msbuild/issues/4094")] + [Fact(Skip = "https://github.com/dotnet/msbuild/issues/11888")] public void DontLockP2PReferenceWhenResolvingSystemTypes() { // This WriteLine is a hack. On a slow machine, the Tasks unittest fails because remoting @@ -3186,7 +3186,7 @@ public class Class1 /// which fails (LoadFile requires an absolute path). The fix was to use /// Assembly.LoadFrom instead. /// - [WindowsFullFrameworkOnlyFact(additionalMessage: "Linked resources not supported on Core: https://github.com/dotnet/msbuild/issues/4094")] + [Fact(Skip = "https://github.com/dotnet/msbuild/issues/11888")] public void ReferencedAssemblySpecifiedUsingRelativePath() { // This WriteLine is a hack. On a slow machine, the Tasks unittest fails because remoting diff --git a/src/Tasks/DownloadFile.cs b/src/Tasks/DownloadFile.cs index efe54f514ca..b606f5c5284 100644 --- a/src/Tasks/DownloadFile.cs +++ b/src/Tasks/DownloadFile.cs @@ -168,7 +168,7 @@ private async Task DownloadAsync(Uri uri, CancellationToken cancellationToken) #endif } - if (!TryGetFileName(response, out string filename)) + if (!TryGetFileName(uri, out string filename)) { Log.LogErrorWithCodeFromResources("DownloadFile.ErrorUnknownFileName", SourceUrl, nameof(DestinationFileName)); return; @@ -306,25 +306,24 @@ private static bool IsRetriable(Exception exception, out Exception actualExcepti /// /// Attempts to get the file name to use when downloading the file. /// - /// The with information about the response. + /// The uri we sent request to. /// Receives the name of the file. /// true if a file name could be determined, otherwise false. - private bool TryGetFileName(HttpResponseMessage response, out string filename) + private bool TryGetFileName(Uri requestUri, out string filename) { - if (response == null) + if (requestUri == null) { - throw new ArgumentNullException(nameof(response)); + throw new ArgumentNullException(nameof(requestUri)); } // Not all URIs contain a file name so users will have to specify one // Example: http://www.download.com/file/1/ - filename = !String.IsNullOrWhiteSpace(DestinationFileName?.ItemSpec) + filename = !string.IsNullOrWhiteSpace(DestinationFileName?.ItemSpec) ? DestinationFileName.ItemSpec // Get the file name from what the user specified - : response.Content?.Headers?.ContentDisposition?.FileName // Attempt to get the file name from the content-disposition header value - ?? Path.GetFileName(response.RequestMessage.RequestUri.LocalPath); // Otherwise attempt to get a file name from the URI + : Path.GetFileName(requestUri.LocalPath); // Otherwise attempt to get a file name from the URI - return !String.IsNullOrWhiteSpace(filename); + return !string.IsNullOrWhiteSpace(filename); } #if !NET6_0_OR_GREATER