Skip to content

Teach Copilot setup about our SDK version #11890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rainersigwald opened this issue May 23, 2025 · 0 comments · May be fixed by #11891
Open

Teach Copilot setup about our SDK version #11890

rainersigwald opened this issue May 23, 2025 · 0 comments · May be fixed by #11891
Assignees
@rainersigwald @Copilot
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself.

Comments

@rainersigwald
Copy link
Member

Right now, our Copilot setup steps try to install a good version of the .NET SDK with this call to setup-dotnet:

msbuild/.github/workflows/copilot-setup-steps.yml

Lines 20 to 22 in 4ad4624

- uses: actions/setup-dotnet@67a3573c9a986a3f9c594539f4ab511d57bb3ce9 # 4.3.1
with:
global-json-file: global.json

However, our global.json is nonstandard: we don't pin an SDK in "the usual way". We use an Arcade-specific tools.dotnet element that setup-dotnet doesn't know about.

Update .github/workflows/copilot-setup-steps.yml to

  1. extract the value of tools.dotnet to get an SDK version to install
  2. pass that to setup-dotnet

I think that may involve a script using jq and setting a GitHub Actions variable in step 1, then using that variable in step 2, but I'd love to hear about better options.
@Copilot Copilot AI linked a pull request May 23, 2025 that will close this issue
Open
@github-actions github-actions bot added the Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rainersigwald rainersigwald

Copilot code review Copilot

Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Copilot setup to use .NET SDK version from tools.dotnet dotnet/msbuild
1 participant
@rainersigwald