--version does not work when you configure an argument on the root command

[blowdart]

I have a configuration like the following

var statusArgument = new Argument<string>("status")
{
    Description = "What you are doing right now?"
};

var allowRepliesOption = new Option<bool>("--allowReplies", "-r", "/r")
{
    Description = "Allow replies to your status update.",
    DefaultValueFactory = defaultValue => true
};

var rootCommand = new RootCommand("Post a quick status update on Bluesky")
{
    statusArgument,
    allowRepliesOption
};

etc.

-h works, but --version takes the argument into account, so I get

Required argument missing for command: 'bloop'.

Edited:

More detailed repro steps below at #2591 (comment).

[jonsequitur]

What was the command line you ran that gave this result?

[blowdart]

bloop --version

(I have the following launchSettings.json)

{
    "profiles": {
        "Bloop": {
            "commandName": "Project",
            "commandLineArgs": "\"Bloop\""
        },
        "Bloop --version": {
            "commandName": "Project",
            "commandLineArgs": "--version"
        },
        "Bloop -?": {
            "commandName": "Project",
            "commandLineArgs": "-?"
        }
    }
}

[jonsequitur]

I'm not able to repro this on version 2.0.0-beta6.25323.104.

[elgonzo]

I also cannot reproduce. That makes me think that for some reason the --version option was not passed to the System.Commandline invocation in your project. Assuming you really started the correct profile with "commandLineArgs": "--version", perhaps the args array/string passed to System.CommandLine got altered beforehand somewhere in your project for some reason, removing the --version string from it.

[jonsequitur]

Additional information that will repro this:

• There needs to be a required option or argument configured but not passed on the command line.
• This results in a parse error but if ParseResult.Invoke is called, the parse error is ignored and version info is displayed. But if you check the ParseResult.Errors, there will be an error present. This is what the docs currently encourage here:

[adamsitnik]

I've failed to reproduce the problem. Here is the app I've used:

using System.CommandLine;

namespace ValidatorsRepro
{
    internal class Program
    {
        static void Main(string[] args)
        {
            bool optionValidatorWasCalled = false;
            bool argumentValidatorWasCalled = false;

            Option<string> option = new("-o");
            option.Validators.Add(_ =>
            {
                optionValidatorWasCalled = true;
            });

            Argument<string> argument = new("the-arg");
            argument.Validators.Add(_ =>
            {
                argumentValidatorWasCalled = true;
            });

            RootCommand rootCommand = new()
            {
                option,
                argument
            };

            rootCommand.Parse(args).Invoke();

            Console.WriteLine(optionValidatorWasCalled);
            Console.WriteLine(argumentValidatorWasCalled);
        }
    }
}

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net8.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="System.CommandLine" Version="2.0.0-beta5.25306.1" />
  </ItemGroup>

</Project>

 dotnet run -c Release -- --version

1.0.0
False
False

@blowdart

[blowdart]

@adamsitnik @jonsequitur found the cause - #2591 (comment)

Serves me right for reading the docs 😂