Mark all command and compiler pass classes as final (#796)

GromNaN · web-flow · commit b07f049b4b66 · 2023-12-10T14:59:43.000+01:00
diff --git a/Command/ClearMetadataCacheDoctrineODMCommand.php b/Command/ClearMetadataCacheDoctrineODMCommand.php
@@ -14,7 +14,7 @@
  *
  * @internal since version 4.7.0
  */
-class ClearMetadataCacheDoctrineODMCommand extends MetadataCommand
+final class ClearMetadataCacheDoctrineODMCommand extends MetadataCommand
 {
     protected function configure(): void
     {
diff --git a/Command/CreateSchemaDoctrineODMCommand.php b/Command/CreateSchemaDoctrineODMCommand.php
@@ -15,7 +15,7 @@
  *
  * @internal since version 4.7.0
  */
-class CreateSchemaDoctrineODMCommand extends CreateCommand
+final class CreateSchemaDoctrineODMCommand extends CreateCommand
 {
     protected function configure(): void
     {
diff --git a/Command/DropSchemaDoctrineODMCommand.php b/Command/DropSchemaDoctrineODMCommand.php
@@ -15,7 +15,7 @@
  *
  * @internal since version 4.7.0
  */
-class DropSchemaDoctrineODMCommand extends DropCommand
+final class DropSchemaDoctrineODMCommand extends DropCommand
 {
     protected function configure(): void
     {
diff --git a/Command/GenerateHydratorsDoctrineODMCommand.php b/Command/GenerateHydratorsDoctrineODMCommand.php
@@ -14,7 +14,7 @@
  *
  * @internal since version 4.7.0
  */
-class GenerateHydratorsDoctrineODMCommand extends GenerateHydratorsCommand
+final class GenerateHydratorsDoctrineODMCommand extends GenerateHydratorsCommand
 {
     protected function configure(): void
     {
diff --git a/Command/GenerateProxiesDoctrineODMCommand.php b/Command/GenerateProxiesDoctrineODMCommand.php
@@ -14,7 +14,7 @@
  *
  * @internal since version 4.7.0
  */
-class GenerateProxiesDoctrineODMCommand extends GenerateProxiesCommand
+final class GenerateProxiesDoctrineODMCommand extends GenerateProxiesCommand
 {
     protected function configure(): void
     {
diff --git a/Command/InfoDoctrineODMCommand.php b/Command/InfoDoctrineODMCommand.php
@@ -20,7 +20,7 @@
  *
  * @internal since version 4.7.0
  */
-class InfoDoctrineODMCommand extends DoctrineODMCommand
+final class InfoDoctrineODMCommand extends DoctrineODMCommand
 {
     protected function configure(): void
     {
diff --git a/Command/LoadDataFixturesDoctrineODMCommand.php b/Command/LoadDataFixturesDoctrineODMCommand.php
@@ -22,7 +22,7 @@
  *
  * @internal since version 4.7.0
  */
-class LoadDataFixturesDoctrineODMCommand extends DoctrineODMCommand
+final class LoadDataFixturesDoctrineODMCommand extends DoctrineODMCommand
 {
     public function __construct(ManagerRegistry $registry, private SymfonyFixturesLoaderInterface $fixturesLoader)
     {
diff --git a/Command/QueryDoctrineODMCommand.php b/Command/QueryDoctrineODMCommand.php
@@ -14,7 +14,7 @@
  *
  * @internal since version 4.7.0
  */
-class QueryDoctrineODMCommand extends QueryCommand
+final class QueryDoctrineODMCommand extends QueryCommand
 {
     protected function configure(): void
     {
diff --git a/Command/ShardDoctrineODMCommand.php b/Command/ShardDoctrineODMCommand.php
@@ -15,7 +15,7 @@
  *
  * @internal since version 4.7.0
  */
-class ShardDoctrineODMCommand extends ShardCommand
+final class ShardDoctrineODMCommand extends ShardCommand
 {
     protected function configure(): void
     {
diff --git a/Command/UpdateSchemaDoctrineODMCommand.php b/Command/UpdateSchemaDoctrineODMCommand.php
@@ -15,7 +15,7 @@
  *
  * @internal since version 4.7.0
  */
-class UpdateSchemaDoctrineODMCommand extends UpdateCommand
+final class UpdateSchemaDoctrineODMCommand extends UpdateCommand
 {
     protected function configure(): void
     {
diff --git a/DataCollector/CommandDataCollector.php b/DataCollector/CommandDataCollector.php
@@ -20,7 +20,7 @@
 use function MongoDB\BSON\toCanonicalExtendedJSON;
 
 /** @internal since version 4.7.0 */
-class CommandDataCollector extends DataCollector
+final class CommandDataCollector extends DataCollector
 {
     public function __construct(private CommandLogger $commandLogger)
     {
diff --git a/DependencyInjection/Compiler/CreateHydratorDirectoryPass.php b/DependencyInjection/Compiler/CreateHydratorDirectoryPass.php
@@ -15,7 +15,7 @@
 use function sprintf;
 
 /** @internal */
-class CreateHydratorDirectoryPass implements CompilerPassInterface
+final class CreateHydratorDirectoryPass implements CompilerPassInterface
 {
     public function process(ContainerBuilder $container): void
     {
diff --git a/DependencyInjection/Compiler/CreateProxyDirectoryPass.php b/DependencyInjection/Compiler/CreateProxyDirectoryPass.php
@@ -15,7 +15,7 @@
 use function sprintf;
 
 /** @internal since version 4.7.0 */
-class CreateProxyDirectoryPass implements CompilerPassInterface
+final class CreateProxyDirectoryPass implements CompilerPassInterface
 {
     public function process(ContainerBuilder $container): void
     {
diff --git a/DependencyInjection/Compiler/DoctrineMongoDBMappingsPass.php b/DependencyInjection/Compiler/DoctrineMongoDBMappingsPass.php
@@ -21,7 +21,7 @@
  *
  * @internal since version 4.7.0
  */
-class DoctrineMongoDBMappingsPass extends RegisterMappingsPass
+final class DoctrineMongoDBMappingsPass extends RegisterMappingsPass
 {
     /**
      * You should not directly instantiate this class but use one of the
diff --git a/UPGRADE-5.0.md b/UPGRADE-5.0.md
@@ -9,7 +9,7 @@ UPGRADE FROM 4.x to 5.0
   `findBundle` and `findBasePathForBundle` methods from
   `Doctrine\Bundle\MongoDBBundle\Command\DoctrineODMCommand` have been
   removed without replacement.
-* The `Doctrine\Bundle\MongoDBBundle\Command\DoctrineODMCommand` class is now
-  `@internal`, you should not extend from this class.
+* All command and compiler pass classes are internal and final. They cannot be
+  used directly or extended.
 * Remove support of Annotation mapping, you should use Attributes or XML instead.
 * Remove `--service` option from `doctrine:mongodb:fixtures:load` command

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`*`
`15`	`15`	`* @internal since version 4.7.0`
`16`	`16`	`*/`
`17`		`-class ClearMetadataCacheDoctrineODMCommand extends MetadataCommand`
	`17`	`+final class ClearMetadataCacheDoctrineODMCommand extends MetadataCommand`
`18`	`18`	`{`
`19`	`19`	`protected function configure(): void`
`20`	`20`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`*`
`16`	`16`	`* @internal since version 4.7.0`
`17`	`17`	`*/`
`18`		`-class CreateSchemaDoctrineODMCommand extends CreateCommand`
	`18`	`+final class CreateSchemaDoctrineODMCommand extends CreateCommand`
`19`	`19`	`{`
`20`	`20`	`protected function configure(): void`
`21`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`*`
`21`	`21`	`* @internal since version 4.7.0`
`22`	`22`	`*/`
`23`		`-class InfoDoctrineODMCommand extends DoctrineODMCommand`
	`23`	`+final class InfoDoctrineODMCommand extends DoctrineODMCommand`
`24`	`24`	`{`
`25`	`25`	`protected function configure(): void`
`26`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`*`
`23`	`23`	`* @internal since version 4.7.0`
`24`	`24`	`*/`
`25`		`-class LoadDataFixturesDoctrineODMCommand extends DoctrineODMCommand`
	`25`	`+final class LoadDataFixturesDoctrineODMCommand extends DoctrineODMCommand`
`26`	`26`	`{`
`27`	`27`	`public function __construct(ManagerRegistry $registry, private SymfonyFixturesLoaderInterface $fixturesLoader)`
`28`	`28`	`{`