Skip to content

Commit 7bbb599

Browse files
authored
Merge pull request #145 from sixeyed/master
Fix .NET Core images
2 parents 258c562 + 82e5790 commit 7bbb599

File tree

7 files changed

+29
-28
lines changed

7 files changed

+29
-28
lines changed

docker-compose-windows-1809.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: "3.2"
33
services:
44
vote:
55
image: dockersamples/examplevotingapp_vote:dotnet-nanoserver-1809
6-
build:
6+
build:
77
context: ./vote/dotnet
88
dockerfile: Dockerfile.1809
99
ports:
@@ -13,12 +13,12 @@ services:
1313

1414
result:
1515
image: dockersamples/examplevotingapp_result:dotnet-nanoserver-1809
16-
build:
16+
build:
1717
context: ./result/dotnet
1818
dockerfile: Dockerfile.1809
1919
ports:
2020
- "5001:80"
21-
environment:
21+
environment:
2222
- "ConnectionStrings:ResultData=Server=db;Port=4000;Database=votes;User=root;SslMode=None"
2323
depends_on:
2424
- db
@@ -28,14 +28,14 @@ services:
2828
build:
2929
context: ./worker/dotnet
3030
dockerfile: Dockerfile.1809
31-
environment:
31+
environment:
3232
- "ConnectionStrings:VoteData=Server=db;Port=4000;Database=votes;User=root;SslMode=None"
3333
depends_on:
3434
- message-queue
3535
- db
3636

3737
message-queue:
38-
image: dockersamples/nats:nanoserver-1809
38+
image: nats:2.0.4
3939

4040
db:
4141
image: dockersamples/tidb:nanoserver-1809
@@ -45,4 +45,4 @@ services:
4545
networks:
4646
default:
4747
external:
48-
name: nat
48+
name: nat

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ services:
3434
- back-tier
3535

3636
redis:
37-
image: redis:alpine
37+
image: redis:5.0-alpine3.10
3838
container_name: redis
3939
ports: ["6379"]
4040
networks:

result/dotnet/Dockerfile.1809

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM microsoft/dotnet:2.1-sdk-nanoserver-1809 as builder
1+
FROM mcr.microsoft.com/dotnet/core/sdk:2.1 as builder
22

33
WORKDIR /Result
44
COPY Result/Result.csproj .
@@ -8,7 +8,7 @@ COPY /Result .
88
RUN dotnet publish -c Release -o /out Result.csproj
99

1010
# app image
11-
FROM microsoft/dotnet:2.1-aspnetcore-runtime-nanoserver-1809
11+
FROM mcr.microsoft.com/dotnet/core/aspnet:2.1
1212

1313
WORKDIR /app
1414
ENTRYPOINT ["dotnet", "Result.dll"]

vote/dotnet/Dockerfile.1809

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM microsoft/dotnet:2.1-sdk-nanoserver-1809 as builder
1+
FROM mcr.microsoft.com/dotnet/core/sdk:2.1 as builder
22

33
WORKDIR /Vote
44
COPY Vote/Vote.csproj .
@@ -8,7 +8,7 @@ COPY /Vote .
88
RUN dotnet publish -c Release -o /out Vote.csproj
99

1010
# app image
11-
FROM microsoft/dotnet:2.1-aspnetcore-runtime-nanoserver-1809
11+
FROM mcr.microsoft.com/dotnet/core/aspnet:2.1
1212

1313
WORKDIR /app
1414
ENTRYPOINT ["dotnet", "Vote.dll"]

worker/Dockerfile

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
1-
FROM microsoft/dotnet:2.0.0-sdk
1+
FROM mcr.microsoft.com/dotnet/core/sdk:2.1 as builder
22

3-
WORKDIR /code
3+
WORKDIR /Worker
4+
COPY src/Worker/Worker.csproj .
5+
RUN dotnet restore
46

5-
ADD src/Worker /code/src/Worker
7+
COPY src/Worker/ .
8+
RUN dotnet publish -c Release -o /out Worker.csproj
69

7-
RUN dotnet restore -v minimal src/Worker \
8-
&& dotnet publish -c Release -o "./" "src/Worker/"
10+
# app image
11+
FROM mcr.microsoft.com/dotnet/core/runtime:2.1
912

10-
CMD dotnet src/Worker/Worker.dll
13+
WORKDIR /app
14+
ENTRYPOINT ["dotnet", "Worker.dll"]
15+
16+
COPY --from=builder /out .

worker/dotnet/Dockerfile.1809

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM microsoft/dotnet:2.1-sdk-nanoserver-1809 as builder
1+
FROM mcr.microsoft.com/dotnet/core/sdk:2.1 as builder
22

33
WORKDIR /Worker
44
COPY Worker/Worker.csproj .
@@ -8,7 +8,7 @@ COPY /Worker .
88
RUN dotnet publish -c Release -o /out Worker.csproj
99

1010
# app image
11-
FROM microsoft/dotnet:2.1-aspnetcore-runtime-nanoserver-1809
11+
FROM mcr.microsoft.com/dotnet/core/runtime:2.1
1212

1313
WORKDIR /app
1414
ENTRYPOINT ["dotnet", "Worker.dll"]

worker/src/Worker/Worker.csproj

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>netcoreapp2.0</TargetFramework>
5-
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
6-
<AssemblyName>Worker</AssemblyName>
74
<OutputType>Exe</OutputType>
8-
<PackageId>Worker</PackageId>
9-
<ServerGarbageCollection>true</ServerGarbageCollection>
10-
<RuntimeFrameworkVersion>2.0.0</RuntimeFrameworkVersion>
5+
<TargetFramework>netcoreapp2.1</TargetFramework>
116
</PropertyGroup>
127

138
<ItemGroup>
14-
<PackageReference Include="StackExchange.Redis" Version="1.1.604-alpha" />
15-
<PackageReference Include="Npgsql" Version="3.1.3" />
16-
<PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
9+
<PackageReference Include="StackExchange.Redis" Version="2.0.601" />
10+
<PackageReference Include="Npgsql" Version="4.0.9" />
11+
<PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
1712
</ItemGroup>
1813

1914
</Project>

0 commit comments

Comments
 (0)