Skip to content

Commit 5b06909

Browse files
committed
fix secrets not found error
1 parent 261cd00 commit 5b06909

File tree

1 file changed

+15
-4
lines changed

1 file changed

+15
-4
lines changed

cmd/docker-mcp/secret-management/secret/secretsengine.go

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"context"
66
"encoding/json"
77
"fmt"
8+
"io"
89
"net"
910
"net/http"
1011
"os"
@@ -58,12 +59,22 @@ func GetSecrets(ctx context.Context) ([]Envelope, error) {
5859
return nil, err
5960
}
6061

62+
// Read body
63+
body, err := io.ReadAll(resp.Body)
64+
resp.Body.Close()
65+
if err != nil {
66+
return nil, fmt.Errorf("failed to read response body for pattern %s: %w", pattern, err)
67+
}
68+
69+
// Skip patterns with no secrets (404 = not found)
70+
if resp.StatusCode == http.StatusNotFound {
71+
continue
72+
}
73+
6174
var secrets map[string][]Envelope
62-
if err := json.NewDecoder(resp.Body).Decode(&secrets); err != nil {
63-
resp.Body.Close()
64-
return nil, err
75+
if err := json.Unmarshal(body, &secrets); err != nil {
76+
return nil, fmt.Errorf("failed to unmarshal response for pattern %s: %w", pattern, err)
6577
}
66-
resp.Body.Close()
6778

6879
// Merge results, deduplicating by ID
6980
for _, env := range secrets["envelopes"] {

0 commit comments

Comments
 (0)