fix mutating list while iterating over it

WebFreak001 · WebFreak001 · commit e7c7f86455a9 · 2022-10-13T18:18:53.000+02:00
diff --git a/dsymbol/src/dsymbol/modulecache.d b/dsymbol/src/dsymbol/modulecache.d
@@ -107,6 +107,8 @@ struct ModuleCache
 	 */
 	void removeImportPaths(const string[] paths)
 	{
+		import std.array : array;
+
 		foreach (path; paths[])
 		{
 			if (!importPaths[].canFind!(a => a.path == path))
@@ -115,7 +117,7 @@ struct ModuleCache
 				continue;
 			}
 
-			foreach (ref importPath; importPaths[].filter!(a => a.path == path))
+			foreach (ref importPath; importPaths[].filter!(a => a.path == path).array)
 				importPaths.remove(importPath);
 
 			foreach (cacheEntry; cache[])

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,8 @@ struct ModuleCache`
`107`	`107`	`*/`
`108`	`108`	`void removeImportPaths(const string[] paths)`
`109`	`109`	`{`
	`110`	`+ import std.array : array;`
	`111`	`+`
`110`	`112`	`foreach (path; paths[])`
`111`	`113`	`{`
`112`	`114`	`if (!importPaths[].canFind!(a => a.path == path))`
`@@ -115,7 +117,7 @@ struct ModuleCache`
`115`	`117`	`continue;`
`116`	`118`	`}`
`117`	`119`
`118`		`- foreach (ref importPath; importPaths[].filter!(a => a.path == path))`
	`120`	`+ foreach (ref importPath; importPaths[].filter!(a => a.path == path).array)`
`119`	`121`	`importPaths.remove(importPath);`
`120`	`122`
`121`	`123`	`foreach (cacheEntry; cache[])`