Remove redundant try/catch blocks from goto-instrument

This does change the exit codes of goto-instrument in the case of
exceptions being thrown.  Doing so eliminates a long-standing
anomoly where goto-instrument had a different exit code for
exceptions to all of the other tools.

Author: martin

src/goto-instrument/goto_instrument_parse_options.cpp

@@ -121,7 +121,6 @@ int goto_instrument_parse_optionst::doit()
   eval_verbosity(
     cmdline.get_value("verbosity"), messaget::M_STATISTICS, ui_message_handler);
 
-  try
   {
     register_languages();
 
@@ -823,30 +822,6 @@ int goto_instrument_parse_optionst::doit()
     help();
     return CPROVER_EXIT_USAGE_ERROR;
   }
-
-  catch(const char *e)
-  {
-    error() << e << eom;
-    return CPROVER_EXIT_EXCEPTION_GOTO_INSTRUMENT;
-  }
-
-  catch(const std::string &e)
-  {
-    error() << e << eom;
-    return CPROVER_EXIT_EXCEPTION_GOTO_INSTRUMENT;
-  }
-
-  catch(int e)
-  {
-    error() << "Numeric exception : " << e << eom;
-    return CPROVER_EXIT_EXCEPTION_GOTO_INSTRUMENT;
-  }
-
-  catch(const std::bad_alloc &)
-  {
-    error() << "Out of memory" << eom;
-    return CPROVER_EXIT_EXCEPTION_GOTO_INSTRUMENT;
-  }
 // NOLINTNEXTLINE(readability/fn_size)
 }
 

src/util/exit_codes.h

@@ -40,7 +40,6 @@ Author: Martin Brain, [email protected]
 /// An (unanticipated) exception was thrown during computation.
 #define CPROVER_EXIT_EXCEPTION 6
 // should contemplate EX_SOFTWARE from sysexits.h
-#define CPROVER_EXIT_EXCEPTION_GOTO_INSTRUMENT 11
 
 /// An error has been encountered during processing the requested analysis.
 #define CPROVER_EXIT_INTERNAL_ERROR 6